Closed
Bug 605340
Opened 14 years ago
Closed 14 years ago
"ASSERTION: Can't find flow containing this frame???"
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
References
Details
(4 keywords)
Attachments
(4 files)
219 bytes,
text/html
|
Details | |
2.94 KB,
text/plain
|
Details | |
837 bytes,
patch
|
Details | Diff | Splinter Review | |
1.41 KB,
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: Can't find flow containing this frame???: 'Error', file layout/generic/nsTextFrameThebes.cpp, line 2158
Reporter | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → matspal
Severity: normal → critical
Keywords: crash,
regression
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 2•14 years ago
|
||
Assignee | ||
Comment 3•14 years ago
|
||
Silly mistake - 'mLastFlowIndex' became out-of-bounds. As I understand it, 'mLastFlowIndex' is just an optimization used as a hint when mapping content -> mapped flow, so any valid index is correct. The last index seems like a good choice. With this patch the testcase still asserts but those will be fixed in bug 604843. This patch is independent of that bug though. I'm adding "[run=0xNNNNNNNN]" to the text frame dump since I often find it useful when debugging.
Attachment #484280 -
Flags: review?(roc)
Attachment #484280 -
Flags: approval2.0?
Comment on attachment 484280 [details] [diff] [review] Patch rev. 1 Test?
Attachment #484280 -
Flags: review?(roc)
Attachment #484280 -
Flags: review+
Attachment #484280 -
Flags: approval2.0?
Attachment #484280 -
Flags: approval2.0+
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/fe4243e45cf1 http://hg.mozilla.org/mozilla-central/rev/898db83dc637
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Comment 6•14 years ago
|
||
Marking this regression a branch blocker for qa verification because bug 571995 is a blocker.
blocking1.9.1: --- → .16+
blocking1.9.2: --- → .13+
status1.9.1:
--- → wanted
status1.9.2:
--- → wanted
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/650e7b0d6d34 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bd03fbc2b2fc http://hg.mozilla.org/releases/mozilla-1.9.1/rev/19e3f097936a http://hg.mozilla.org/releases/mozilla-1.9.1/rev/91bf1ee0a8ac http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5cb35072f373 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6444dcb39b02 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/64e803656a1f http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ee365bf30311 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0ac503e14b53 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1d2fa8e53cc3 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/57ce1356af46 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3956db8d0373
You need to log in
before you can comment on or make changes to this bug.
Description
•