Closed
Bug 605427
Opened 14 years ago
Closed 13 years ago
Implement FpReg move on icc or fcc for asm_cmov()
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tamarin)
Attachments
(1 file)
|
11.16 KB,
patch
|
wmaddox
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Summary: Implement FpReg move on icc for asm_cmov() → Implement FpReg move on icc or fcc for asm_cmov()
Attachment #485260 -
Flags: review?(wmaddox)
|
||
Updated•14 years ago
|
Attachment #485260 -
Flags: review?(wmaddox) → review+
|
|
||
Comment 2•14 years ago
|
||
R+
nits:
inline void Assembler::FMOVDcc
(Register rs, int32_t opt_cc, Register rd, int32_t cond, const char *opcode) {
- Don't break the line before the argument list -- it's not excessively long by the standards of the rest of the file.
- Our preferred convention, per discussion some months ago, is that the * should associate with the type, not the variable, e.g., char* rather than char *. The code elsewhere in this file isn't consistent, however, so if you're just going with the immediate neighborhood, that's ok.http://hg.mozilla.org/projects/nanojit-central/rev/ce344dfb7fcb Fixed the line break. Leave the "char *opcode" for future fixes.
Whiteboard: fixed-in-nanojit
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/tamarin-redux/rev/e952f880d3f6
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin
Can this be closed? Waiting to land in TM?
Flags: flashplayer-qrb+
Flags: flashplayer-bug-
this one is already landed on MC. http://hg.mozilla.org/mozilla-central/rev/16c78e2e5c30
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•