Closed
Bug 605999
Opened 14 years ago
Closed 14 years ago
Stop sticking virtual stuff in C++ blocks in nsIDOMWindowUtils
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta7+ |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.44 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
See bug 596743 comment 7. This needs to block b7, sadly... I'll see if I can write up a patch for this tonight.
|
Assignee | |
Updated•14 years ago
|
blocking2.0: --- → beta7+
|
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #484955 -
Flags: review?(roc)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
Attachment #484955 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #484955 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 484960 [details] [diff] [review] Don't put stuff that changes the vtable in a C++ block. With more feeling.
Attachment #484960 -
Flags: review?(roc)
Attachment #484960 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/91c3496d58cb And on relbranch: http://hg.mozilla.org/mozilla-central/rev/702a5ebcb7a6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla2.0b7
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•