606103 - Name crypto background thread so it can be identified by OS tools

Status: RESOLVED INVALID

(Firefox :: Sync, enhancement)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

See bug 606062 comment 0: having a named Sync thread can be very useful when gross profiling, because with named threads can simply look at which threads are chewing CPU in a tool like |top| and say, e.g., "oh, the Sync thread is quiet".

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Name the Weave/Sync background thread "gecko.Sync"

Comment 2

[Philipp von Weitershausen [:philikon]]

The thread in question isn't where Sync does its work, it's just where we do the crypto. I suggest calling it "gecko.ServicesCrypto" or something similar.

Note that this should land in fx-sync (we periodically merge to m-c). It will thus live in the add-on code as well which may be installed on older 4.0 betas that don't have nsIThread::newNamedThread. We might want to retain a fallback to newThread(0).

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 484968 [details] [diff] [review]
Name the Weave/Sync background thread "gecko.Sync"

Philipp's comments should be addressed.

Comment 4

[Mike Connor [:mconnor]]

We've backed out off-main-thread crypto since individual calls are so short with all-AES crypto.  INVALID?

Comment 5

[Philipp von Weitershausen [:philikon]]

Yup.