Closed
Bug 606251
Opened 14 years ago
Closed 14 years ago
Cannot run tests a second time without restarting the test harness
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: mossop, Assigned: Gavin)
Details
Attachments
(1 file)
967 bytes,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
It used to be the case that at the end of the run I could click the run tests button and have it re-run the tests, even with any changes I made to the test files on OSX and Linux where they are just symlinked. Now clicking the run tests button a second time displays the error about no matching tests.
Assignee | ||
Comment 1•14 years ago
|
||
So this looks to be an issue whose underlying cause is bug 366941. server.js's arrayOfTestFiles() uses |for (var [link, value] in linkArray)|, where linkArray is actually a plain object. The reason it isn't failing consistently is that the JSContext where the relevant server.js script is being evaluated changes versions between the first invocation and the second. In the first invocation, it's 170, and in the second, it's 185. I'm not sure what would be triggering the version change (I did check that it's the same JSContext in both cases).
Assignee | ||
Comment 2•14 years ago
|
||
This fixes the bug so that things work regardless of what version the code is run under.
Reporter | ||
Comment 3•14 years ago
|
||
Comment on attachment 495358 [details] [diff] [review] patch Changing versions on the context sounds sorta bad, do we have a bug on file for that?
Attachment #495358 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Looks like bug 595691 will be taking care of that.
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/986384241027
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Flags: in-testsuite-
Version: unspecified → Trunk
Updated•6 years ago
|
Component: BrowserTest → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•