606511 - Bug.search should allow use of include_fields and exclude_fields

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[David Lawrence [:dkl]]

Attachment: Patch to allow include/exclude_fields to be used with Bug.search (v1)

Since Bug.search is calling _bug_to_hash for each returned bug, it should also then allow the use of include_fields and exclude_fields. Currently if you pass in those params, you will get an error that those are not allow param values for match(). The attached patch allows the new params to be used properly.

Dave

Comment 1

[Max Kanat-Alexander]

Thank you so much for writing this patch, I totally wanted it to happen. :-)

Comment 2

[Max Kanat-Alexander]

Comment on attachment 485312 [details] [diff] [review]
Patch to allow include/exclude_fields to be used with Bug.search (v1)

I think a simpler piece of code would be to copy the entire input $params to another hash, then delete the two items from the original hash, and pass the copied hash to _bug_to_hash.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to allow include/exclude_fields to be used with Bug.search (v2)

Thanks for the review Max. Here is an updated patch with your suggested change.

Dave

Comment 4

[Max Kanat-Alexander]

Comment on attachment 485656 [details] [diff] [review]
Patch to allow include/exclude_fields to be used with Bug.search (v2)

Beautiful. :-)

Comment 5

[David Lawrence [:dkl]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk
modified Bugzilla/WebService/Bug.pm
Committed revision 7573.

Comment 7

[Max Kanat-Alexander]

Needs checking in on 4.0 also.

Comment 8

[David Lawrence [:dkl]]

4.0:
Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/   modified Bugzilla/WebService/Bug.pm
Committed revision 7546.