60666 - javascript strict warnings in pref-search.js

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/pref/pref-search.js line 59: redeclaration of var
defaultEngineURI

Comment 1

[Mark Olson]

Attachment: proposed patch

Comment 2

[Mark Olson]

Looking at this again, i noticed that InitSingleEngineList() and
setDefaultSearchEngine() are unused.  Attaching a patch that removes those
obsolete functions and some other dead code. Adding jag for r=

Comment 3

[Mark Olson]

Attachment: patch - more agressive cleanup

Comment 4

[timeless]

r=timeless :-)

Comment 5

[Blake Ross]

cc'ing alec for sr

Comment 6

[Peter "jag" Annema]

 * Contributor(s): Robert John Churchill ([e-mail])
 *                 Mark Olson ([e-mail])

I believe the preferred way to write this is:

 * Contributor(s):
 *   Robert John Churchill <[e-mail]>
 *   Mark Olson <[e-mail]>

Optionally with "(Original Author)" appended to the deserving name :-)

No need to attach a new patch, but could whoever ends up checking this in (I'm
sure someone will beat me to it) fix that?

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 8

[timeless]

fix checked in

Comment 9

[Henrik Gemal]

I cant see the warnings with todays build 20010619.
Will reopen if I see them again.

Please add the following line to your prefs.js file, so we could avoid all 
these strict warning fixup...:
user_pref("javascript.options.strict", true);