606859 - Unable to add Sherlock search plugin

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Mycroft Project (CC)]

Am unable to add any Sherlock search plugins recently - haven't checked with builds before and after but bug 599751 seems like the obvious candidate esp. as the error is:

_onLoad: Failed to init engine!
ReferenceError: valueEnd is not defined

Linked url gives example to try.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Ineed, valueEnd is used outside the block where it is declared - let makes that an error.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/859ffcd7933a

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: test

Comment 4

[[e-mail]]

This bug was caused by not applying some of the whitespace changes :-(

To be specific, Serge had outdented the block in question (which was an else after return, so should never have been indented in the first place) which would have meant that let would have worked.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/2797d4bc3f2d

Comment 6

[Mycroft Project (CC)]

Confirm now works as expected again.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Thanks for catching this, Charles.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as verified fixed then.