60820 - changes made shouldn't persist until you hit OK

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, enhancement, P3)

Description

[sairuh (rarely reading bugmail)]

apologies if this already exists somewhere --i couldn't find one like this after
a couple of queries. from a usability pov, we shouldn't be applying prefs
changes until the OK button for the prefs dialog is clicked. two examples of
where this 'rule' is broken are the Helper Applications and Themes panels. if
the user wishes to undo changes made in prefs, hitting the Cancel button should
clear away those changes [not apply them to the app].

unfortunately, this same behavior is what occurs in 4.x [at least using 4.74 on
linux]. i imagine that fixing this to Do The Right Thing would be non-trivial...
will add helpwanted kw soon...

Comment 1

[sairuh (rarely reading bugmail)]

kw-o-rama.

Comment 2

[sairuh (rarely reading bugmail)]

adding dependency...

Comment 3

[Samir Gehani]

Taking.  

se to find bugs for history and helper apps related to this bug.

Comment 4

[Samir Gehani]

Moving to mozilla0.9.8.

Comment 5

[sairuh (rarely reading bugmail)]

erk, i'm not having luck finding the helper app or history bugs related to this
issue... :(

Comment 6

[Samir Gehani]

Moving to milestone after mozilla0.9.9 (mozilla1.0 for now).

Comment 7

[Samir Gehani]

Prefs triage team: need separate bugs for each offender to be tracked by this
meta-bug.

Comment 8

[Blake Ross]

The only bug that this tracked (44032) has been fixed. Please file a new bug to
the proper component (whoever owns the pref panel in question) if there are
remaining issues.

Comment 9

[sairuh (rarely reading bugmail)]

agreed, among these are prefs within the history and cache panels...

anyhow, rs vrfy.