Closed
Bug 608428
Opened 14 years ago
Closed 14 years ago
Replace default icon in desktop notifications
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec2.0+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0+ | --- |
People
(Reporter: dougt, Assigned: alexp)
Details
Attachments
(2 files, 3 obsolete files)
1.80 KB,
image/png
|
madhava
:
ui-review+
|
Details |
4.51 KB,
patch
|
alexp
:
review+
|
Details | Diff | Splinter Review |
On android, because we can not specify the icon of our notifications, we are using the default application icon for all desktop notifications: http://dougt.org/wordpress/wp-content/uploads/n2.png We discussed this a bit and would like to use a different icon on Android. The icon should convey the idea of a notification from fennec, but not fennec itself.
Reporter | ||
Updated•14 years ago
|
tracking-fennec: --- → ?
Reporter | ||
Comment 1•14 years ago
|
||
madhava, could you help here? AlexP, could you provide the exact specifications (size, type) for this icon?
Assignee: nobody → madhava
tracking-fennec: ? → 2.0+
Assignee | ||
Comment 2•14 years ago
|
||
We need hi-DPI icons, which are 38x38 PNGs. The guidelines are here: http://developer.android.com/guide/practices/ui_guidelines/icon_design.html#statusbarstructure But the actual icon sizes used in real Android system and apps are different than mentioned in that document (which says 48x48). Here you can find the actual image files for reference (stat_*.png are the ones used for the status bar): http://android.git.kernel.org/?p=platform/frameworks/base.git;a=tree;f=core/res/res/drawable-hdpi;hb=HEAD
Comment 3•14 years ago
|
||
Updated•14 years ago
|
Assignee: madhava → alexp
Assignee | ||
Updated•14 years ago
|
Attachment #490167 -
Flags: ui-review?(madhava)
Assignee | ||
Comment 4•14 years ago
|
||
Should this new icon be used for the update notifications as well?
Comment 5•14 years ago
|
||
(In reply to comment #4) > Should this new icon be used for the update notifications as well? No. This new icon should only be used for web-based notifications (notifications created by the web page).
Comment 6•14 years ago
|
||
That's right - this icon is specifically intended to mean "the web page wants to tell you something."
Updated•14 years ago
|
Attachment #490167 -
Flags: ui-review?(madhava) → ui-review+
Assignee | ||
Comment 7•14 years ago
|
||
Use R.drawable.alert in GeckoAppShell.showAlertNotification() by default.
Attachment #491984 -
Flags: review?(blassey.bugs)
Assignee | ||
Comment 8•14 years ago
|
||
- Added the new icon - Made UpdatePrompt to continue using the main app icon for the update notifications
Attachment #491986 -
Flags: review?(mark.finkle)
Comment 9•14 years ago
|
||
Comment on attachment 491984 [details] [diff] [review] Fix why do we want this change? I think this bug is just about using the desktop notification icon for desktop notifications
Assignee | ||
Comment 10•14 years ago
|
||
(In reply to comment #9) > why do we want this change? I think this bug is just about using the desktop > notification icon for desktop notifications As far as I understand this is about default icon - if no icon is provided in the call to showAlertNotification(), or the one is not found in the existing resources, use the new notification icon instead of the app icon.
Comment 11•14 years ago
|
||
Comment on attachment 491984 [details] [diff] [review] Fix (In reply to comment #10) > (In reply to comment #9) > > why do we want this change? I think this bug is just about using the desktop > > notification icon for desktop notifications > > As far as I understand this is about default icon - if no icon is provided in > the call to showAlertNotification(), or the one is not found in the existing > resources, use the new notification icon instead of the app icon. No, this bug is about notifications form web pages having the same icon as notifications from the application (with all the implied trust level etc. etc.).
Attachment #491984 -
Flags: review?(blassey.bugs) → review-
Reporter | ||
Comment 12•14 years ago
|
||
what brad said.
Assignee | ||
Comment 13•14 years ago
|
||
Specify a new icon in desktop notifications.
Attachment #491984 -
Attachment is obsolete: true
Attachment #491986 -
Attachment is obsolete: true
Attachment #492472 -
Flags: review?(blassey.bugs)
Attachment #491986 -
Flags: review?(mark.finkle)
Updated•14 years ago
|
Attachment #492472 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 14•14 years ago
|
||
The patch contains the icon itself as well. r=blassey a=blocking-fennec
Attachment #492472 -
Attachment is obsolete: true
Attachment #492541 -
Flags: review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 15•14 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/fe7649100f19
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Keywords: checkin-needed
Comment 16•13 years ago
|
||
VERIFIED FIXED: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110608 Firefox/7.0a1 Fennec/7.0a1 Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110607 Firefox/6.0a2 Fennec/6.0a2 Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•