60865 - xremote should return a different error code for window not found vs. error

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect, P3)

Description

[Christopher Blizzard (:blizzard)]

When you use mozilla -remote there's no way to tell if it was because the window
was not found or if it was because there was an error on the server.  To build a
decent launcher script I need this functionality.

Comment 1

[Christopher Blizzard (:blizzard)]

Index: nsAppRunner.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/nsAppRunner.cpp,v
retrieving revision 1.250
diff -u -r1.250 nsAppRunner.cpp
--- nsAppRunner.cpp     2000/11/07 08:04:06     1.250
+++ nsAppRunner.cpp     2000/11/22 23:09:35
@@ -1099,7 +1099,7 @@
       // was there a window not running?
       if (!success) {
         PR_fprintf(PR_STDERR, "No running window found.\n");
-        return 1;
+        return 2;
       }
       client->Shutdown();
       // success

Comment 2

[Brendan Eich [:brendan]]

r=[e-mail]

Comment 3

[tor]

a=tor

Comment 4

[Alec Flett]

sorry, been having SERA issues - I could have sworn I sr=alecf'ed this twice
already, guess it never went through :(

Comment 5

[Christopher Blizzard (:blizzard)]

Nope, I never heard a peep.  Thanks!

Comment 6

[Christopher Blizzard (:blizzard)]

Fix checked in.