60907 - Set default action to be Open for the helper app dialog if a helper app is present

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Scott MacGregor]

This bug came out of a phone call discussion with some real audio folks today.

Currently, when the helper app dialog is invoked, we currently preselect the
Save To Disk radio button.

If you want to open using a helper app you have to click the open radio button
every time.

Desired behavior: If we've detected the presence of a helper app to use, then we
should default the dialog to have "Open" pre-selected.

Comment 1

[sairuh (rarely reading bugmail)]

methinks this is the default action in 4.x...

Comment 2

[Scott MacGregor]

Adding some real audio folks to the cc list as they are interested in this bug. 

Comment 3

[Scott MacGregor]

Attachment: proposed fix

Comment 4

[Scott MacGregor]

Here's the proposed fix. When we bring up the helper app dialog, if we detect
that we already have a helper app to initialize the dialog with then be sure to
preselect the Open radio button instead of the Save To Disk radio button. 

Comment 5

[Jesse Ruderman]

Which file types/mime types/helper apps does this happen for?  I wouldn't want 
the default action to be "open" for excel spreadsheets, which can contain 
scripts, or for zip archives, since my handler for .zip decompresses into the 
current directory without prompting.

Comment 6

[Scott MacGregor]

the default action doesn't mean you don't get the helper app dialog, we just
start it off with the Open With "Excel" radio button selected by default instead
of Save To Disk.

The user still gets a dialog and they can change it to save to disk before any
harm is done. 

Comment 7

[Alec Flett]

looks good
sr=alecf

Comment 8

[(not reading, please use [e-mail] instead)]

r=sspitzer

Comment 9

[Scott MacGregor]

I just checked in the fix for this into the trunk. If a helper app is present,
the dialog always defaults to "Open". Otherwise it defaults to "Save To Disk".

Thanks for the code reviews guys. 

Comment 10

[selmer (gone)]

Scott, please check this in on the branch ASAP.

Comment 11

[Scott MacGregor]

done (this has been landed on the branch)

Comment 12

[shrirang khanzode]

verified on trunk(1211) and branch (1211) builds that this is working as 
expected.

Comment 13

[sairuh (rarely reading bugmail)]

*** Bug 62637 has been marked as a duplicate of this bug. ***