609422 - Insert and Format entries in menubar in MailNews Compose window enable on hover

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Ian Neal]

In classic theme, the Insert and Format entries in the MailNews Compose window are disabled when the focus is not in the message body part of the window, but when you hover over the entries they become enabled (but not usable).
Steps to reproduce:
1/ Open a compose window
2/ Click into the address widget
3/ Note the Insert and Format entries in the menubar are greyed out
4/ Hover over either of the entries

Actual result:
1/ Entries no longer greyed out

Expected result:
1/ Entries stay greyed out

Comment 1

[Ian Neal]

Looks like this is from:
/mozilla/toolkit/themes/gnomestripe/global/menu.css

menu[disabled="true"],
menuitem[disabled="true"] {
  color: GrayText;
}
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/gnomestripe/global/menu.css#70

Comes before:

menubar > menu[_moz-menuactive="true"] {
  color: -moz-menubartext;
}
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/gnomestripe/global/menu.css#89

which means it no longer shows as disabled.

For winstripe and pinstripe :not([disabled="true"]) is used to stop it having an effect (and on the -moz-lwtheme entry), so perhaps that is the way to go?

As in toolkit changing to correct product.

Comment 2

[Ian Neal]

Attachment: Add not disabled to _moz-menuactive line patch v0.1 [Checked in: Comment 4]

This patch:
* Adds a :not([disabled="true"]) to the _moz-menuactive line in the gnomestripe menu.css line.

Cannot see any regressions when tested in Firefox, fixes issue in SeaMonkey.

Comment 3

[Ian Neal]

Comment on attachment 488364 [details] [diff] [review]
Add not disabled to _moz-menuactive line patch v0.1 [Checked in: Comment 4]

Low impact, low risk theme fix - as far as I can see this will effect SeaMonkey only.

Comment 4

[Ian Neal]

Comment on attachment 488364 [details] [diff] [review]
Add not disabled to _moz-menuactive line patch v0.1 [Checked in: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/4563259585a2