610187 - Clarify browser-places.js dependencies (was "Error: PlacesMenu is not defined")

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101106 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101106 Firefox/4.0b8pre

Error: PlacesMenu is not defined
Source File: chrome://browser/content/browser.js
Line: 2925

Reproducible: Always

Steps to Reproduce:
1. Check "Load this bookmark in the sidebar" for any bookmark
2. Close the sidebar if it is open
3. Left-click the bookmark to open
Actual Results:  
The above error is reported in Error Console.

Comment 1

[Marco Bonardo [:mak]]

confirmed in latest trunk

Comment 2

[Marco Bonardo [:mak]]

Mano, the sidebar does not include global-scripts.inc where PlacesMenu is defined, but it imports browser.js...
I think either we make it use global-scripts.inc (removing the current browser.js and inlineSpellCheckUI.js imports), we move browserPlacesViews.js to PlacesOverlay or we workaround the issue since the sidebar is most likely not needing those views (by checking if PlacesMenu is in scope or by making a mock of it in the overlay).
What's your suggestion?

Comment 3

[dguerrero]

Seems fixed now in FF4 beta 10. At least the Bugzilla sidebar, that has been broken for all FF4 versions, is working now.

Comment 4

[Marco Bonardo [:mak]]

No, it's not fixed.

Comment 5

[Marco Bonardo [:mak]]

Bug 632411 solved the error, but we really need to clarify browser-places dependencies.

Comment 6

[Michelle Funches - QA]

No longer reproducible.
Version 	48.0a1
Build ID 	20160314030215
User Agent 	Mozilla/5.0 (Windows NT 5.1; rv:48.0) Gecko/20100101 Firefox/48.0
Considering this I will mark this issue as Resolved-WORKSFORME. If anyone can still reproduce it, feel free to reopen the issue and provide more information.

Comment 7

[Marco Bonardo [:mak]]

see comment 5.
The error doesn't happen anymore cause we put a workaround for it, but the dependencies problem still exists.

Comment 8

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.