610408 - Can't see full screen window controls, bookmark overflow chevron or tab or sidebar close button when using dark lwtheme

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[[e-mail]]

Some lightweight themes, such as "Cheese grater - mini", have a very dark background and it this makes it difficult to see some of the UI.

Comment 1

[[e-mail]]

Attachment: Proposed patch

* Makes the window controls visible by forcing them to have a plain background
* Tweaks the chevron and closebutton images so that instead of two black pixels
  they have one black and one dark grey pixel. (Note that I used #808080 as my
  dark grey, while Firefox went for #999999 in their chevron.)

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #1)
> Created attachment 488894 [details] [diff] [review]
> Proposed patch
> 
> * Makes the window controls visible by forcing them to have a plain background

Too bad we can't apply a rule based on whether the lwtheme has a dark background. We can only check whether the text color is bright or dark, and a bright text color can go with both a dark and a bright lwtheme (with text-shadow in the latter case). :-( For example I think "samotne drzewo" looks better without the change. But having clearly visible controls is more important of course.

Since we cannot apply transparency to -moz-Dialog either (at least AFAIK we could only use rgba(r,g,b,a), but that would mean not using the OS colors), f=me for this if you want it (the chevron/closebutton changes were so subtle that I overlooked them initially, but I appreciate them).

Comment 3

[[e-mail]]

Pushed changeset 50d164d40d14 to comm-central.