611060 - Support both -r and -l in Disassemble, allow options in DisassFile

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Paul Biggar]

Attachment: patch

-r and -l don't both work together, and no options are supported in DisassFile. this fixes both problems.

Comment 1

[Igor Bukanov]

Comment on attachment 489547 [details] [diff] [review]
patch

>+"dis([fun])               Disassemble functions into bytecodes",
>+"disfile('foo.js')        Disassemble script file into bytecodes\n"
>+"  dis() and disfile() can be preceeded with\n"
>+"    \"-r\" (disassemble recursively)\n"
>+"    \"-l\" (show line numbers)",


Nice help!

Comment 2

[Brendan Eich [:brendan]]

(In reply to comment #1)
> Comment on attachment 489547 [details] [diff] [review]
> patch
> 
> >+"dis([fun])               Disassemble functions into bytecodes",
> >+"disfile('foo.js')        Disassemble script file into bytecodes\n"
> >+"  dis() and disfile() can be preceeded with\n"
> >+"    \"-r\" (disassemble recursively)\n"
> >+"    \"-l\" (show line numbers)",

Should add "arguments " before "can", or something like that. The "()" are a kind of post-fix <code>...</code> convention but not really helping here.

Try this:

"  Both dis and disfile take these options as leading string arguments:\n"

/be

Comment 3

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/12d38422c622