611328 - Replace Utils.trace() calls with Utils.assert().

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Sean Dunn]

In bug 567029, dietrich caught some areas for code cleanup:

not related to this patch really, but those trace() calls should be assert()s,
no? and if we don't need to throw an error, then we certainly shouldn't ship
with those. please file a followup for it, either way.

Comment 1

[Kevin Hanes]

Punting

Comment 2

[Marco Túlio Costa]

Attachment: Simple bug. I felt like leaving the asserts inside the if's.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 550576 [details] [diff] [review]
Simple bug. I felt like leaving the asserts inside the if's.

Review of attachment 550576 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Marco, thanks for the patch! If you address my comments below I'll be happy to review your patch again :)

::: browser/base/content/tabview/groupitems.js
@@ +527,2 @@
>        return;
>      }

Let's just make that:

Utils.assert(Utils.isRect(inRect), 'GroupItem.setBounds: rect is not a real rectangle!');

So we can remove the if clause and the return statement because we'll just assert when there's a wrong argument (which is consistent with how we usually handle that).

::: browser/base/content/tabview/tabitems.js
@@ +345,5 @@
>    // Possible options:
>    //   force - true to always update the DOM even if the bounds haven't changed; default false
>    setBounds: function TabItem_setBounds(inRect, immediately, options) {
>      if (!Utils.isRect(inRect)) {
> +      Utils.assert(false, 'TabItem.setBounds: rect is not a real rectangle!');

(see above)

@@ +453,5 @@
>  
>      rect = this.getBounds(); // ensure that it's a <Rect>
>  
>      if (!Utils.isRect(this.bounds))
> +      Utils.assert(false, 'TabItem.setBounds: this.bounds is not a real rectangle!');

(see above)

Comment 4

[Marco Túlio Costa]

Attachment: Removed the if's

You were right. It's much cleaner now.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 550881 [details] [diff] [review]
Removed the if's

Review of attachment 550881 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Now we need the patch to be ready for check-in...
http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

It would be great if you can make the patch ready, upload it here and mark the bug with the "checkin-needed" keyword. Looking forward to see that fixed! :)

Comment 6

[Marco Túlio Costa]

Attachment: [checked-in] Better formatted

Thanks to Bonardo's blog post.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Thanks for the patch, Marco!

http://hg.mozilla.org/integration/fx-team/rev/5776ff214937

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 551984 [details] [diff] [review]
[checked-in] Better formatted

http://hg.mozilla.org/mozilla-central/rev/5776ff214937