612401 - "Could not get engine: clients" in Sync log

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Long-standing little bug. Clients is a special engine; updateEnabledEngines needs to know about it and not complain on failure.

(Alternatively, EngineManagerSvc needs to know about it and return it when asked.)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 515806 [details] [diff] [review]
Proposed patch. v1

Yay for removing spurious logging.

Comment 3

[Richard Newman [:rnewman]]

Pushed to fx-sync:

http://hg.mozilla.org/services/fx-sync/rev/543d4b41daf1

Comment 4

[Philipp von Weitershausen [:philikon]]

Merged to s-c: http://hg.mozilla.org/services/services-central/rev/1a0094bc7086

Comment 5

[Philipp von Weitershausen [:philikon]]

Merged to m-c: http://hg.mozilla.org/mozilla-central/rev/1a0094bc7086

Comment 6

[Tracy Walker [:tracy]]

Engine.Clients appears to be fine with beta12 on stage

Comment 7

[Philipp von Weitershausen [:philikon]]

(In reply to comment #6)
> Engine.Clients appears to be fine with beta12 on stage

This only landed in mozilla-central today, not in beta12. It also doesn't fix a bug with the clients engine, it just gets rid of an annoying, misleading and unnecessary log message.