612414 - XrayWrapper.cpp:239:21: warning: converting to non-pointer type ‘uintN’ from NULL

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Daniel Holbert [:dholbert]]

> js/src/xpconnect/wrappers/XrayWrapper.cpp: In function ‘bool xpc::ResolveNativeProperty(JSContext*, JSObject*, JSObject*, jsid, bool, JSPropertyDescriptor*)’:
> js/src/xpconnect/wrappers/XrayWrapper.cpp:239:21: warning: converting to non-pointer type ‘uintN’ from NULL

Code:
> 237     desc->getter = NULL;
> 238     desc->setter = NULL;
> 239     desc->shortid = NULL;
> 240     desc->value = JSVAL_VOID;

The "shortid" member var is a uintN (unsigned integer), so it should be set to 0 rather than null.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 490717 [details] [diff] [review]
trivial fix

Requesting landing approval. Trivial fix w/ no functional impact -- just a s/NULL/0/ to fix a build warning.

Comment 3

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/mozilla-central/rev/6d7b682a3cc4