Closed
Bug 612588
Opened 14 years ago
Closed 14 years ago
Toolbars outside of the toolbox should be visible while customizing, just like those inside of the toolbox
Categories
(Toolkit :: Toolbars and Toolbar Customization, defect)
Toolkit
Toolbars and Toolbar Customization
Tracking
()
VERIFIED
FIXED
mozilla2.0b8
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.66 KB,
patch
|
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
This was fixed in bug 599325 for Firefox, but toolkit code should handle this.
Attachment #490880 -
Flags: review?(enndeakin)
|
||
Updated•14 years ago
|
Attachment #490880 -
Flags: review?(enndeakin) → review+
|
Assignee | |
Updated•14 years ago
|
Attachment #490880 -
Flags: approval2.0?
|
||
Comment 1•14 years ago
|
||
Comment on attachment 490880 [details] [diff] [review] patch a+. thanks for whipping up the right fix for this!
Attachment #490880 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 490880 [details] [diff] [review] patch Hrm, actually, there's no test for this. Is there already one in the tree? If so it should be modified for add-on bar.
Attachment #490880 -
Flags: approval2.0+ → approval2.0-
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 490880 [details] [diff] [review] patch I don't think this needs a test.
Attachment #490880 -
Flags: approval2.0- → approval2.0?
|
||
Comment 4•14 years ago
|
||
Why not just leave the existing test, but have it use computed style rather than checking .collapsed ?
|
|
Assignee | |
Comment 5•14 years ago
|
||
The test makes me nervous, I'd rather get rid of it. I don't understand why it opens a "chromeless window", which seems entirely non-standard.
|
|
Assignee | |
Comment 6•14 years ago
|
||
cleaned up the test
Attachment #490880 -
Attachment is obsolete: true
Attachment #492276 -
Flags: approval2.0?
Attachment #490880 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
Attachment #492276 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6c4cca9bd105
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Comment 8•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101204 Firefox/4.0b8pre ID:20101204030328
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•