612980 - Make Node inherit from EventTarget

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Cameron McCormack (:heycam)]

We should experiment with making Node (and other interfaces that implement EventTarget) extend from EventTarget rather than mixing it in.  As perhaps the most popular mixed in interface, it would be helpful for authors to be able to get at the single, canonical property that defines addEventListener, etc.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

To make it clear: the goal here is to get specs updated to make EventTarget be the root of Node as well as other interfaces.

The following interfaces should also inherit EventTarget:

Window
XMLHttpRequest
Worker (also SharedWorker in spec, we don't implement this interface yet)
FileReader
IDBDatabase
IDBTransaction
IDBRequest
WebSocket
EventSource (in patch, not yet landed)

There's probably more that I'm forgetting.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yes! This is exactly what I want.
WebIDL had(has?) something else for some time, and I was going to complain about 
it.

EventTarget should be the one XHR and Node and Window etc inherit.
(Internally nsINode, nsGlobalWindow, XHR, etc inherit nsPIDOMEventTarget)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #1)
> There's probably more that I'm forgetting.

In other words nsINode, Window, whatever inherits nsDOMEventTargetHelper
and Worker's global.

Comment 4

[Cameron McCormack (:heycam)]

Olli, is it too late to change this in DOM 3 Events (realising of course that it is not written in Web IDL, though)?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I don't see how this has anything to do with DOM 3 Events.

Comment 6

[Cameron McCormack (:heycam)]

Er yeah, my mistake, it's an issue for DOM Core etc.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I believe this is done now, yes?  Anything left to do here?