Closed
Bug 613074
Opened 14 years ago
Closed 14 years ago
[Manage Versions page] Delete confirmation for add-on files
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
5.12.4
People
(Reporter: krupa.mozbugs, Assigned: andy+bugzilla)
References
()
Details
(Whiteboard: [z])
steps to reproduce: 1. Load https://addons-next.allizom.org/z/en-US/developers/addon/64250/versions/114026 2. Click on delete icon for one of the listed files expected behavior: There is a delete confirmation dialog box actual behavior: The file is deleted
Comment 1•14 years ago
|
||
We already have "Save or Cancel" on the bottom of the form, and nothing happens until you click one of those. Is this necessary?
Comment 2•14 years ago
|
||
I personally think it's weird to commit a file deletion using a Save button. I'd prefer to have the confirmation and then delete the file without needing to Save. </ui-nazi>
Comment 3•14 years ago
|
||
If deleting a file is applied instantaneously, we should move files into a separate block (i.e. 'item_wrapper'), so its clear that Save/Cancel does not apply to it. Another idea: Instead of hiding the row when it's deleted, replace it with a stub that informs the user it will be destroyed on delete, along with an option to save right now or undo the delete. Something like this: +----------------------------------------------------------------------------+ | he_heha_ha-20100729.xpi will be deleted on save. [Save Now] [Undo] | +----------------------------------------------------------------------------+ The benefits: * Users can delete multiple files without a refresh inbetween. * Offering an undo option rather than a delete confirmation, which is almost always better (http://www.alistapart.com/articles/neveruseawarning/) and could come at little cost in this case. But: * The user could still forget to save, even with the prompt. This isn't unprecedented either: there are several places we have editable lists around DevTools (icons, screenshots, authors) that require a save action from the surrounding form. However, the save button isn't initially visible on this page, like it is on some others.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → amckay
Assignee | ||
Comment 4•14 years ago
|
||
I like chowse's idea. Would it be enough to say something like "click save or cancel to undo" - the ui elements are there already to undo the deletion at the bottom of the form.
Assignee | ||
Comment 5•14 years ago
|
||
https://github.com/jbalogh/zamboni/commit/f4c9fbd7d121f074689e04d80578d37dc1de397f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•14 years ago
|
||
verified @ https://addons.allizom.org/z/en-US/developers/addon/64250/versions/121782 on clicking delete, "This file will be deleted on save. Undo" is shown. Clicking "Undo" will cancel the delete Delete is saved on clicking save. Thanks
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•