613198 - Changing the "No Proxy for" list UI from a textbox to a textarea

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, enhancement)

Description

[Edmund Wong (:ewong)]

Currently, both in 2.0.10 and 2.1b2pre the "No Proxy" list is a textbox widget.  That being the case, entering more than 4 or 5 hosts (depending on length
of each host name) it will need scrolling.   

Changing this to a textarea will allow the user the ability to easily
view the previous host entries.  

Right now, the 'no proxy for' list is a comma-delimited entry. Optionally 
changing the format of the entries to a line based entry might be easier 
on the eyes.

Comment 1

[Ian Neal]

textarea sounds promising but I'd keep with comma-delimited entries.

Comment 2

[Edmund Wong (:ewong)]

Attachment: Changed the No Proxy textbox to multiline textbox.

Comment 3

[Ian Neal]

Comment on attachment 501936 [details] [diff] [review]
Changed the No Proxy textbox to multiline textbox.

Looks good to me, I don't think it has any css or os x implications, so should be ready to checkin.

Comment 4

[[e-mail]]

I'm not 100% convinced by the alignment of the label:
              +-------------------------------------+
              |localhost, 127.0.0.1                 |
No Proxy For: |                                     |
              |                                     |
              +-------------------------------------+
<row align="baseline"> seems to give a more pleasing effect. Ian?

[Note to self: access keys on the labels aren't working?]

Comment 5

[[e-mail]]

(In reply to comment #4)
> [Note to self: access keys on the labels aren't working?]
[Buggy build. Three other builds are OK.]

Comment 6

[Ian Neal]

(In reply to comment #4)
> I'm not 100% convinced by the alignment of the label:
>               +-------------------------------------+
>               |localhost, 127.0.0.1                 |
> No Proxy For: |                                     |
>               |                                     |
>               +-------------------------------------+
> <row align="baseline"> seems to give a more pleasing effect. Ian?
Agreed.

Comment 7

[Edmund Wong (:ewong)]

Attachment: Changed the No Proxy textbox to multiline textbox.

Changed align="center" to align="baseline" as per comment #5.

Comment 8

[[e-mail]]

(In reply to comment #7)
> Created attachment 502725 [details] [diff] [review]
> Changed the No Proxy textbox to multiline textbox.
> 
> Changed align="center" to align="baseline" as per comment #5.

Actually comment #5 said <row align="baseline"> ...

Comment 9

[[e-mail]]

Sorry, I forgot to describe the effect I was looking for, which is this:
              +-------------------------------------+
No Proxy For: |localhost, 127.0.0.1                 |
              |                                     |
              |                                     |
              +-------------------------------------+

Comment 10

[Edmund Wong (:ewong)]

Attachment: Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox

Comment 11

[[e-mail]]

Comment on attachment 502765 [details] [diff] [review]
Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox

>-            <row align="center"> 
>+            <row align="baseline"> 
Nit: As you're changing this line anyway, you could remove the trailing space.

Comment 12

[Edmund Wong (:ewong)]

Attachment: Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox [Checkin: comment 13]

Fixed trailing space nit.

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 502768 [details] [diff] [review]
Changed the "No Proxy for" list UI from a single line textbox to a multiline textbox [Checkin: comment 13]

http://hg.mozilla.org/comm-central/rev/533a76b1095a