61368 - Trunk: unresolved symbols

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Jim Dunn]

A recent change to config/rules.mk (rev 3.2.54), caused a problem
with HP building mozilla-bin.  nsMPFileLocProvider::nsMPFileLocProvider()
and nsAppFileLocationProvider::nsAppFileLocationProvider()
which are found in libxpfelocation_s.a & libmpfilelocprovider_s.a.
However because the the 'needed' change to rules.mk the SHARED_LIBRARY_LIBS
are no longer being included.

So my suggested fix is: Chris, what do you think?

Index Makefile.in
=================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v
retrieving revision 1.103
diff -u -r 1.103 Makefile.in
--- Makefile.in 2000/11/20 07:15:42    1.103
+++ Makefile.in 2000/11/28 22:04:14
@@ -35,13 +35,9 @@
 PROGRAM                 = mozilla-bin
 endif

-EXTRA_DSO_LIBS = gkgfx
-
-ifeq ($MOZ_WIDGET_TOOLKIT),os2)
-EXTRA_DSO_LIBS += xpfelocation_s mpfilelocprovider_s
-else
-SHARE_LIBRARY_LIBS = -lxpfelocation_s -lmpfilelocprovider_s
-endif
+EXTRA_DSO_LIBS = gkgfx \
+               xpfelocation_s mpfilelocprovider_s \
+               $(NULL)

 CPPSRCS

Comment 1

[Jim Dunn]

updating...

Comment 2

[cls]

Looks good to me. r=cls

Comment 3

[Jim Dunn]

Adding mike since I am removing his ifdef,
and basically using his makefile path for all platforms.

Comment 4

[cls]

The patch has been checked in.  Marking fixed.

Comment 5

[David Krause]

Oooh, this fixed part of the OpenBSD build problems as well.

Comment 6

[Barrett Lindstrom]

verified