613795 - Add a possibility to Data Manager to only list domains of a certain data type

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Robert Kaiser]

In order for making it easier to find all your passwords or permissions, etc. in Data Manager, it would be good to have a way to only list domains that have this data type available.
This also will enable us elegantly to e.g. replace calls to "View Cookies" (that opens Cookie Manager right now) with a call to Data Manager with only cookie domains listed.
I have a patch working locally for the add-on already.

Comment 1

[Robert Kaiser]

Attachment: v1: add a selector for data types

Here's a patch for the SeaMonkey version to allow selecting data types - including an option for loading this as a "view" on Data Manager launch.

Comment 2

[Robert Kaiser]

Attachment: v1.1: make sure loading all-type views still works

While developing for the next steps, I realized that we need to make sure calls to all-type views still work when Data Manager is already open and a specific data type selected. This new patch fixes that and adds a test for this case.

Comment 3

[Robert Kaiser]

Attachment: v1.2: minimal tweak to view loading

Sorry for yet another iteration, but I found it's more correct to switch to listing all domains _before_ walking the displayed domains array in search of a domain, so I tweaked the view loading code again slightly.

Comment 4

[Robert Kaiser]

Attachment: v1.3: update for | separator in view caller syntax

This patch switches the separator for view calls to |, see bug 588418.

Comment 5

[Robert Kaiser]

Attachment: v1.4: adjust to changed test

In bug 588418, I added a few more test cases and that would have needed changes here anyhow, so I switched to a somewhat saner testing infrastructure as well (at first, I hadn't expected that this one would cover that many cases). This patch only contains updates for those changes.

Comment 6

[Ian Neal]

Comment on attachment 496217 [details] [diff] [review]
v1.4: adjust to changed test

r=me

Comment 7

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/35e9872fd19f