614301 - [Kitsune] String "There are no threads. Maybe you should create some!" cannot be localized

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Pavel Cvrcek [:JasnaPaka]]

1) Visit https://support-stage-new.mozilla.com/cs/kb/Jak%20nastavit%20domovskou%20str%C3%A1nku/discuss
2) You will see string "There are no threads. Maybe you should create some!" which we cannot localize.

Comment 1

[James Socol [:jsocol, :james]]

Will try to get to these before 2.4.

Comment 2

[Paul Craciunoiu [:paulc]]

I thought we decided we don't want to localize these because it's not worth it?

E.g.
https://github.com/jsocol/kitsune/blob/7213950d4bfa32928fa5c21d543a2ed96c4b914e/apps/forums/templates/forums/posts.html#L88
https://github.com/jsocol/kitsune/blob/7213950d4bfa32928fa5c21d543a2ed96c4b914e/apps/forums/templates/forums/forums.html#L30
https://github.com/jsocol/kitsune/blob/7213950d4bfa32928fa5c21d543a2ed96c4b914e/apps/forums/templates/forums/forums.html#L41

Comment 3

[James Socol [:jsocol, :james]]

(In reply to comment #2)
> I thought we decided we don't want to localize these because it's not worth it?

That holds true for the `forums` app, since those forums were never empty and only in English. It doesn't hold true in `kbforums` where 1) they are in fact localized, and 2) most of them are empty.

Comment 4

[Paul Craciunoiu [:paulc]]

master:
https://github.com/jsocol/kitsune/commit/76ba8fa1a2c209d49d812d239739c0cc6dba94fd

Comment 6

[Rebecca Billings [:rbillings]]

Unable to verify- string remains same as comment 1. Would a localizer please verify this?

Comment 7

[Pavel Cvrcek [:JasnaPaka]]

Looks good for me. See: https://master.support.mozilla.com/cs/kb/Jak%20nastavit%20domovskou%20str%C3%A1nku/discuss

v=pcvrcek

Thanks!