Closed
Bug 614717
Opened 14 years ago
Closed 14 years ago
Make test_bug369787.js not hang when the test fails
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file, 1 obsolete file)
1.04 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
If change_content_type throws an exception in test_bug369787.js, do_test_finished is never called and the test hangs. Still trying to figure out why the test fails for me but not tinderbox, but meanwhile the attached patch fixes the hang when that happens.
Assignee | ||
Updated•14 years ago
|
Attachment #493146 -
Attachment is patch: true
Attachment #493146 -
Attachment mime type: application/octet-stream → text/plain
Attachment #493146 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → cbiesinger
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Found the actual reason for the failure - I have a systemwide PAC file set. onStartRequest should set channel to request. This patch does that (in addition to the try..catch from the previous version).
Attachment #493146 -
Attachment is obsolete: true
Attachment #493152 -
Flags: review?(bzbarsky)
Attachment #493146 -
Flags: review?(bzbarsky)
Comment 2•14 years ago
|
||
Comment on attachment 493152 [details] [diff] [review] patch v2 r=me
Attachment #493152 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1cb9c0d5b701
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•