Closed
Bug 615200
Opened 14 years ago
Closed 13 years ago
Update eBay DE Search Plugin
Categories
(Mozilla Localizations :: de / German, defect)
Mozilla Localizations
de / German
Tracking
(blocking2.0 final+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: kev, Assigned: kev)
References
Details
(Keywords: productization, Whiteboard: [hardblocker][fx4-fixed-bugday])
Attachments
(1 file, 1 obsolete file)
3.29 KB,
patch
|
sethb
:
review+
|
Details | Diff | Splinter Review |
Per eBay's request, please update the search plugin to be included with Mozilla products per the attached patch. The changes add suggested search (not yet active) and cut the current number of redirects from the initial search query from 4 to 1. This change should block Fx4 for the DE locale.
Attachment #493672 -
Flags: review?(stas)
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Assignee | ||
Comment 1•14 years ago
|
||
Apologies, forgot to update the favicon as well, per eBay request.
Attachment #493672 -
Attachment is obsolete: true
Attachment #493674 -
Flags: review?(stas)
Attachment #493672 -
Flags: review?(stas)
Updated•14 years ago
|
blocking2.0: ? → final+
Updated•14 years ago
|
Assignee: nobody → kev
Updated•14 years ago
|
Keywords: productization
Whiteboard: productization → [hardblocker]
Assignee | ||
Updated•14 years ago
|
Attachment #493674 -
Flags: review?(stas) → review?(sethb)
Comment 2•14 years ago
|
||
Comment on attachment 493674 [details] [diff] [review] Patch for eBay DE Search Plugin This looks good. Thank you, Kev! As mentioned in the bug, can you please check this into your L10n-central repository, adding a comment that references bug 615200, this change, and r=sethb. Please test the new build and sign off. Once you have signed off, please resolve this bug again as fixed. Thanks to all.
Attachment #493674 -
Flags: review?(sethb) → review+
Comment 3•13 years ago
|
||
checked in: http://hg.mozilla.org/l10n-central/de/rev/3669624dcef5
Comment 4•13 years ago
|
||
Thanks, Kadir. After some nightly testing, can you sign off on this change and then resolve this bug as fixed? I appreciate the quick turnaround.
Comment 5•13 years ago
|
||
bot sure how to test, but ebay search works, so I guess this is done.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•13 years ago
|
||
Can verify the icon update, no more brown color in the 'e'. Though I am getting 2 301 moved responses. [17:45:42.729] GET http://rover.ebay.com/rover/1/707-37276-17702-4/4?mpre=http://shop.ebay.de/?_nkw=desire [HTTP/1.1 301 Moved Permanently 297ms] [17:45:43.028] GET http://rover.ebay.de/rover/1/707-37276-17702-4/4?mpre=http%3A%2F%2Fshop.ebay.de%2F%3F_nkw%3Ddesire%26rvr_id%3D207339811434&cguid=f2db0f7812d0a0aa14e4d7e4ff800a4e [HTTP/1.1 301 Moved Permanently 391ms] Not something we have control over though. Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b11) Gecko/20100101 Firefox/4.0b11 DE locale
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
Whiteboard: [hardblocker] → [hardblocker][fx4-fixed-bugday]
Comment 7•13 years ago
|
||
Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.
You need to log in
before you can comment on or make changes to this bug.
Description
•