Closed Bug 615314 Opened 14 years ago Closed 14 years ago

be silent on uninitialized textures

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file)

Be silent on undefined texture images
2.90 KB, patch
vlad
: review+
joe
: approval2.0+
Details | Diff | Splinter Review 
We currently generate JS warnings when rendering with "fake black" textures, and special-case uninitialized textures (i.e. textures where texImage2D has not yet been called).

However, that latter case of uninitialized textures is very common and legitimate (asynchronous texture loading). So that warning is just noise in most cases.

This patch removes it.
Attachment #493769 - Flags: review?(vladimir)
Attachment #493769 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/b308f615ba23
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee: nobody → bjacob
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: