615528 - gfx/ots/src/Makefile.in randomly clobbers VISIBILITY_FLAGS ifndef MOZ_ENABLE_LIBXUL instead of using config/system-headers

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[timeless]

ld: warning: ots::OTSStream::Write(void const*, unsigned long)has different visibility (default) in ../../gfx/ots/src/libmozots.a(vdmx.o) and (hidden) in gfxUserFontSet.o
[lots of these]

ld: warning: unsigned long const& std::min<unsigned long>(unsigned long const&, unsigned long const&)has different visibility (default) in ../../gfx/ots/src/libmozots.a(ots.o) and (hidden) in gfxUserFontSet.o
[a handful of these]

this crude patch "fixed" the above warnings:
diff --git a/gfx/ots/include/opentype-sanitiser.h b/gfx/ots/include/opentype-sanitiser.h
--- a/gfx/ots/include/opentype-sanitiser.h
+++ b/gfx/ots/include/opentype-sanitiser.h
@@ -7,2 +7,4 @@
 
+#pragma GCC visibility push(default)
+
 #if defined(_MSC_VER)

@@ -185,2 +190,4 @@ void DisableDebugOutput();
 
+#pragma GCC visibility pop
+
 #endif  // OPENTYPE_SANITISER_H_

I'll post the more correct patch to config/system-headers after i get off battery power and can verify it works

Comment 1

[Mike Hommey [:glandium]]

This is because of http://mxr.mozilla.org/mozilla-central/source/gfx/ots/src/Makefile.in#35

No idea why it's there.

Comment 2

[timeless]

ok, glandium figured this out, it happens ifndef MOZ_ENABLE_LIBXUL, because of a random block in the Makefile.

Comment 3

[timeless]

Attachment: this fixes disable-libxul

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 494062 [details] [diff] [review]
this fixes disable-libxul

Well, apparently the system wrapper is not even necessary.

Comment 5

[timeless]

Attachment: patch

Comment 6

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/56dd675c96f3