616085 - The test case for bug 508908 touches network, causes grief, lack of sleep, and tree closure

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[(no longer active)]

This test touches the network to load a Flash file: <http://mxr.mozilla.org/mozilla-central/source/layout/generic/crashtests/508908-1.html?force=1#22>.  It happened today that there were some DNS issues on zombo.com, which caused the crashtest suite to fail to unload.  I will file another bug about why this happened in the first place, but I'm disabling this test for now, to be able to reopen the tree.

Comment 1

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/baa5ae44f0ba

Comment 2

[(no longer active)]

I filed bug 616088 for the underlying issue.

Comment 3

[Dão Gottwald [:dao]]

There's no bug on fixing and re-enabling the test, is there? Reopening to track this properly.

Comment 4

[Dão Gottwald [:dao]]

Actually, this probably doesn't need bug 616088, it looks like the test just needs to use a local rather than a remote resource.

Comment 5

[(not currently active) Ted Mielczarek]

Ouch. Thanks for tracking that down! I can't believe we still have tests that hit the network. :-/

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sorry about that!!!!!!

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

All we need to do to reenable the test is to replace <embed src="http://zombo.com/inrozxa.swf"> with <embed type="application/x-test">.

Comment 8

[Phil Ringnalda (:philor)]

We also need to do that on 1.9.2 and 1.9.1, where we're still merrily hitting zombo.com

Comment 9

[Phil Ringnalda (:philor)]

Err, 1.9.2, since the test isn't on 1.9.1.

Comment 10

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/c5e11345cd0b

Comment 11

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b4529434e248

Comment 12

[Phil Ringnalda (:philor)]

And back out again in http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e9231477e05b since unreasonable though this is, bug 629851 happened on all three platforms, and I didn't have a lot of choices other than to back out a crashtest change to see if that will fix a failure in a mochitest. Shrug.

Comment 13

[Phil Ringnalda (:philor)]

And back in again in http://hg.mozilla.org/releases/mozilla-1.9.2/rev/caf45231174c, since it wasn't actually at fault.

Comment 14

[Daniel Veditz [:dveditz]]

The "3.6.15" we're releasing today does not fix this bug, the release containing this bug fix has been renamed to "3.6.16" and the bugzilla flags will be updated to reflect that soon. Today's release is a re-release of 3.6.14 plus a fix for a bug that prevented many Java applets from starting up.