616130 - Need pref to disable tab tear off

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P5)

Description

[Mostafa]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12

This problem occured for me many times specially in my netbook.
Some times I want to select an opened tab between my open tabs, ( with default touch mouse plane of netbook ) firefox move that tab to a new window !
Please add a feature to disable moving tabs to new window by drag / dropping them.

Reproducible: Always

Actual Results:  
The bug is clear


The bug is clear

Comment 1

[Tim (fmdeveloper)]

You can disable tab tear off with an extension - https://addons.mozilla.org/en-US/firefox/addon/12276/ (More info: http://mozillalinks.org/wp/2009/07/disable-tab-tearing-and-six-other-firefox-3-5-tab-tweaks/)

Comment 3

[t8av]

In bug https://bugzilla.mozilla.org/show_bug.cgi?id=868800 I did not say it CAN be disabled, I said it MUST be disabled.

In other words: if there will be a user-defined option, its default should be "NO tab tear off".

Comment 4

[t8av]

I wander, why do Firefox developers insist to include features that nobody wants, nobody uses, and only interrupt the web surfing experience?

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to t8av from comment #4)
> include features that nobody
> wants, nobody uses

How do you know (asking seriously)?

Comment 6

[t8av]

Well, so far, I haven't met anyone who uses it.

I did meet many users who get annoyed by this feature.

The above add-on to disable tab tear off is very popular, and since I installed it, I am happy with it.

I am not a cynical person, but if I were cynical I would probably suggest to add many surprises to Firefox - clicking some areas of the browser will trigger interesting events such as tab tear offs, funny animations, etc'. Nobody will complain, but after a while everyone will move to Google Chrome.

Comment 7

[Dave Garrett]

I use tab tear off from time to time and it's more discoverable than a context menu this way. That being said, a built-in option to disable should be in there. Now that I think about it, it might even be helpful for disability access in the event that a user has trouble with fine pointer movements. (e.g. wants to reorder tabs but avoid tear off)

Note that the addon to disable this has only 8k users, which is virtually zero when it comes to addon user counts. A built-in option would certainly be more discoverable and get more use.

Comment 8

[Jan Sonntag]

I would like to pick up this quite old request for an option to disable tab detachment.

I wrote a small patch to implement this behaviour but since i'm relatively new to firefox development, I have no idea who I can ask for review? A bit of help would be greatly appreciated!

Comment 9

[Gingerbread Man]

(In reply to Jan Sonntag from comment #8)

I have no idea who I can ask for review?

Have a look at recently fixed bugs in this component and see who reviewed those patches. Also see the documentation:

1. How to submit a patch
2. Code review
3. Modules/Firefox

Comment 10

[Jan Sonntag]

Attachment: Bug 616130 - Add option to disable tab detaching r=dao

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/951b824337c6
Add option to disable tab detaching r=dao

Comment 12

[Dão Gottwald [:dao]]

This will be resolved when the patch merges to mozilla-central.

Comment 13

[Jan Sonntag]

Okay, thanks for letting me know :)

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/951b824337c6