616236 - [sq] Productization for Fennec in Albanian

Status: RESOLVED FIXED

(Mozilla Localizations :: sq / Albanian, defect)

Description

[Axel Hecht [:Pike]]

Right now, fennec's productization with search and handlers is almost en-US, it just has bloglines left, which is gone in en-US.

Probably good to get a sq.wikipedia.org plugin for mobile?

Besnik, other suggestions?

PS: Status quo is good enough to take for Beta.

Comment 1

[Besnik Bleta]

Shouldn't it be just porting of what's been done for (sq) the elder brother, Firefox. It would be convenient for me too :)

Comment 2

[Staś Małolepszy :stas]

Not really 'just porting' as we do have different guidelines for Mobile: https://wiki.mozilla.org/L10n:Mobile/Productization (max 5 plugins, 1 plugin of each type).

For the beta release, I would suggest just bootstrapping the search engines with google, wikipedia-sq and possibly twitter. We can decide later if adding amazon is a good choice. Ideally, we would also add some kind of a local search engine, something like a yellow pages directory or something similar.

Regarding the wikipedia-sq plugin, please note that you will need to copy it from browser/ and edit slightly. See https://wiki.mozilla.org/L10n:Integrated_Search_Instructions#Wikipedia_plug-in for more details.

As for google (and twitter, if you would like to include it), they area present in en-US, which means that adding their names to list.txt is enough.

Comment 3

[Axel Hecht [:Pike]]

http://hg.mozilla.org/l10n-central/sq/rev/8cb6a38f7b33 has changes for this bug.

Besnik, please attach patches to bugs before changing productization pieces, that avoids having to go back and forth over issues.

This landing is not good enough. Doesn't help that things changed since stas wrote his last comment, too. mobile is using the mobile version of wikipedia now, see http://hg.mozilla.org/mozilla-central/file/630b62652f17/mobile/locales/en-US/searchplugins/wikipedia.xml and the actual change was http://hg.mozilla.org/mozilla-central/rev/e26066134fb6

Also, en-US uses generic descriptions for the plugins, see http://hg.mozilla.org/mozilla-central/diff/ab53d8dabe8f/mobile/locales/en-US/searchplugins/wikipedia.xml and http://hg.mozilla.org/mozilla-central/diff/ab53d8dabe8f/mobile/locales/en-US/searchplugins/amazondotcom.xml.

Please also remove the copies of the en-US plugins, they're not used by the build anyway.

And please with a patch before landing, thanks.

Comment 4

[Besnik Bleta]

Attachment: Patching searchplugins for sq/mobile

This patch should address the issues here, hopefully.

Comment 5

[Besnik Bleta]

Attachment: Patching searchplugins for sq/mobile - fixing names and list.txt

Comment 7

[Axel Hecht [:Pike]]

Reopening, as this isn't fixed.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 589153 [details] [diff] [review]
Patching searchplugins for sq/mobile - fixing names and list.txt

Review of attachment 589153 [details] [diff] [review]:
-----------------------------------------------------------------

r- on this patch, as it doesn't fix the build bustage.

Also, please request reviews before landing by setting the 'review' flag to '?', and only landed after you got a positive review on the changes.

::: mobile/searchplugins/wikipedia.xml
@@ +10,3 @@
>    <Param name="search" value="{searchTerms}"/>
>    <Param name="sourceid" value="Mozilla-search"/>
>  </Url>

We'll need a mobile version named wikipedia-sq.xml

::: mobile/searchplugins/yahoo.xml
@@ +11,3 @@
>  </Url>
>  <SearchForm>http://search.yahoo.com/</SearchForm>
>  </SearchPlugin>

yahoo.xml and the other files that correspond to en-US should be plain removed, and not changed.

Comment 9

[Besnik Bleta]

Attachment: Patching searchplugins for sq/mobile

Comment 10

[Milos Dinic [:Milos]]

Comment on attachment 625503 [details] [diff] [review]
Patching searchplugins for sq/mobile

Besnik,

you did well setting the r?, but you just needed to add bugmail of those whom you're requesting review from to that box to the right of the "?" selector.

Also, when attaching your patches, set the type to "patch".

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 625503 [details] [diff] [review]
Patching searchplugins for sq/mobile

Review of attachment 625503 [details] [diff] [review]:
-----------------------------------------------------------------

r-, the wikipedia.xml should not be removed, but renamed to wikipdia-sq.xml

Comment 12

[Besnik Bleta]

(In reply to Milos Dinic [:Milos] from comment #10)
> Comment on attachment 625503 [details] [diff] [review]
> Patching searchplugins for sq/mobile
> 
> Besnik,
> 
> you did well setting the r?, but you just needed to add bugmail

Theoretically yes, but in my case the bugmail is an alias of the same guy who has complete control over this bug.

Thank you for caring, all the same.


 of those
> whom you're requesting review from to that box to the right of the "?"
> selector.
> 
> Also, when attaching your patches, set the type to "patch".

Comment 13

[Besnik Bleta]

> r-, the wikipedia.xml should not be removed, but renamed to wikipdia-sq.xml

Actually, my locale /searchplugins has only two files, list.txt and wikipedia-sq.xml. The diff I submitted for review came for running "hg diff". Should I use another method? If so, which one?

Comment 14

[Axel Hecht [:Pike]]

hg diff will show what ends up in the remote repo, so there's actions missing.

It's hard to tell remotely, I suggest that you back up the wikipedia plugin. Then I'd try:

mv wikipedia-sq.xml wikipedia.xml
hg add wikipedia.xml
hg mv wikipedia.xml wikipedia-sq.xml

That would undo the move in the file system and do the move in hg, which also does it on file.

Comment 15

[Besnik Bleta]

Attachment: Patching searchplugins for sq/mobile

Thanx Pike!
Here's the output of your suggestion.

Comment 16

[Milos Dinic [:Milos]]

Comment on attachment 627551 [details] [diff] [review]
Patching searchplugins for sq/mobile

Review of attachment 627551 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/searchplugins/wikipedia-sq.xml
@@ +1,2 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Wikipedia</ShortName>

Please change <ShortName> value to Wikipedia(sq), so that user would know that it's gonna be in Albanian.

@@ +1,4 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Wikipedia</ShortName>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAACXBIWXMAAAsTAAALEwEAmpwYAAADGGlDQ1BQaG90b3Nob3AgSUNDIHByb2ZpbGUAAHjaY2BgnuDo4uTKJMDAUFBUUuQe5BgZERmlwH6egY2BmYGBgYGBITG5uMAxIMCHgYGBIS8/L5UBFTAyMHy7xsDIwMDAcFnX0cXJlYE0wJpcUFTCwMBwgIGBwSgltTiZgYHhCwMDQ3p5SUEJAwNjDAMDg0hSdkEJAwNjAQMDg0h2SJAzAwNjCwMDE09JakUJAwMDg3N+QWVRZnpGiYKhpaWlgmNKflKqQnBlcUlqbrGCZ15yflFBflFiSWoKAwMD1A4GBgYGXpf8EgX3xMw8BSMDVQYqg4jIKAUICxE+CDEESC4tKoMHJQODAIMCgwGDA0MAQyJDPcMChqMMbxjFGV0YSxlXMN5jEmMKYprAdIFZmDmSeSHzGxZLlg6WW6x6rK2s99gs2aaxfWMPZ9/NocTRxfGFM5HzApcj1xZuTe4FPFI8U3mFeCfxCfNN45fhXyygI7BD0FXwilCq0A/hXhEVkb2i4aJfxCaJG4lfkaiQlJM8JpUvLS19QqZMVl32llyfvIv8H4WtioVKekpvldeqFKiaqP5UO6jepRGqqaT5QeuA9iSdVF0rPUG9V/pHDBYY1hrFGNuayJsym740u2C+02KJ5QSrOutcmzjbQDtXe2sHY0cdJzVnJRcFV3k3BXdlD3VPXS8Tbxsfd99gvwT//ID6wIlBS4N3hVwMfRnOFCEXaRUVEV0RMzN2T9yDBLZE3aSw5IaUNak30zkyLDIzs+ZmX8xlz7PPryjYVPiuWLskq3RV2ZsK/cqSql01jLVedVPrHzbqNdU0n22VaytsP9op3VXUfbpXta+x/+5Em0mzJ/+dGj/t8AyNmf2zvs9JmHt6vvmCpYtEFrcu+bYsc/m9lSGrTq9xWbtvveWGbZtMNm/ZarJt+w6rnft3u+45uy9s/4ODOYd+Hmk/Jn58xUnrU+fOJJ/9dX7SRe1LR68kXv13fc5Nm1t379TfU75/4mHeY7En+59lvhB5efB1/lv5dxc+NH0y/fzq64Lv4T8Ffp360/rP8f9/AA0ADzT6lvFdAAAAIGNIUk0AAHolAACAgwAA+f8AAIDpAAB1MAAA6mAAADqYAAAXb5JfxUYAAAHqSURBVHjapJUxb9NQFIW/JAip2xNS1/J+goeqUqeajdGVmFgwI1OcmYEgITFG7EgJQ+b2HzgbElJF+QU2iBl7YAFRnQ5+fnFcB0J8Jp/r53vPu+f6vYEA4JBTTjhkN/zkio9kAAihpyr1v/ijN7ovEHqiffFeDHTAdx6wL46HnPX4HM6HHNEHR0NGvRKMhvRE7wT3ACYssBggpyThIRMCAFaEzHhOiQWumfGFBQGQY0kB9EKSCsVCyKpQxUMhdOEMj4Vi91wIGX2uyNJtwTDHAgbjOUBJ/T50ETDAzCn0CiRpLkSd2VW1rqZR6uOpzHoWl40EkmkIlTIhNJc0bUSlSNNtCaZCKGtpyDZimXB92uhBhTEAHzx/BuQ8Isb62Dti16c7PahrNnbovFhXLGQaau4oqDSULDx/BcCl55cEDTUdCqqagWcXbjpqWD8ZWxRUGq5ZOTYhAXLHV0DU/qCtQLJCkZuM0PHQGThvL152JJh5M61SP2CpMpmmgdsTFDJCiaaubq0haQ7Q3xLUZq4NqzS0DNzWxNq8ksgbFmGgwf95oFgijJuB6v9L3Fx2HSg3XeExZxv1xuSEXQt/o8fqg9cDHfB15zuxjRuOETrfu/5b9bhcf+mlRmLgr/cTgp1vqR9c8YlvALcDAPr5jIx+4LKcAAAAAElFTkSuQmCC</Image>

This is 32x32 image, please use:

<Image width="16" height="16">data:image/x-icon;base64,AAABAAEAEBAQAAEABAAoAQAAFgAAACgAAAAQAAAAIAAAAAEABAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAEAgQAhIOEAMjHyABIR0gA6ejpAGlqaQCpqKkAKCgoAPz9/AAZGBkAmJiYANjZ2ABXWFcAent6ALm6uQA8OjwAiIiIiIiIiIiIiI4oiL6IiIiIgzuIV4iIiIhndo53KIiIiB/WvXoYiIiIfEZfWBSIiIEGi/foqoiIgzuL84i9iIjpGIoMiEHoiMkos3FojmiLlUipYliEWIF+iDe0GoRa7D6GPbjcu1yIiIiIiIiIiIiIiIiIiIiIiIiIiIiIiIgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA</Image>

instead.

@@ +5,5 @@
> +<Url type="application/x-suggestions+json" method="GET" template="http://sq.wikipedia.org/w/api.php">
> +  <Param name="action" value="opensearch"/>
> +  <Param name="search" value="{searchTerms}"/>
> +</Url>
> +<Url type="text/html" method="GET" template="http://sq.m.wikipedia.org/wiki">

Please use http://sq.m.wikipedia.org/wiki for <Url> as we'd rather have Wikipedia do the redirect to mobile website.

@@ +9,5 @@
> +<Url type="text/html" method="GET" template="http://sq.m.wikipedia.org/wiki">
> +  <Param name="search" value="{searchTerms}"/>
> +  <Param name="sourceid" value="Mozilla-search"/>
> +</Url>
> +<SearchForm>http://sq.wikipedia.org/wiki/Kërkim:Special</SearchForm>

<SearchForm> is wrong. It should be <SearchForm>http://sq.wikipedia.org/wiki/Speciale:K%C3%ABrkim</SearchForm>

Comment 17

[Milos Dinic [:Milos]]

Besnik,

Also, I forgot to mention: if you find this unpleasant to work on, I can code the plugin for you.

Comment 18

[Besnik Bleta]

(In reply to Milos Dinic [:Milos] from comment #17)

Thank you for your help.

I'm confused about the request about <Image></Image> value. Isn't that 16x16? And the one other locales are using?

You mean http://sq.wikipedia.org/wiki instead of the actual http://sq.m.wikipedia.org/wiki , don't you?

Comment 19

[Milos Dinic [:Milos]]

(In reply to Besnik Bleta from comment #18)
> (In reply to Milos Dinic [:Milos] from comment #17)
> 
> Thank you for your help.
> 
> I'm confused about the request about <Image></Image> value. Isn't that
> 16x16? And the one other locales are using?

It's not 16x16, not the one you used in this patch. So, the sole data representation of that image, or what you put within <Image> tags is:

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAACXBIWXMAAAsTAAALEwEAmpwYAAADGGlDQ1BQaG90b3Nob3AgSUNDIHByb2ZpbGUAAHjaY2BgnuDo4uTKJMDAUFBUUuQe5BgZERmlwH6egY2BmYGBgYGBITG5uMAxIMCHgYGBIS8/L5UBFTAyMHy7xsDIwMDAcFnX0cXJlYE0wJpcUFTCwMBwgIGBwSgltTiZgYHhCwMDQ3p5SUEJAwNjDAMDg0hSdkEJAwNjAQMDg0h2SJAzAwNjCwMDE09JakUJAwMDg3N+QWVRZnpGiYKhpaWlgmNKflKqQnBlcUlqbrGCZ15yflFBflFiSWoKAwMD1A4GBgYGXpf8EgX3xMw8BSMDVQYqg4jIKAUICxE+CDEESC4tKoMHJQODAIMCgwGDA0MAQyJDPcMChqMMbxjFGV0YSxlXMN5jEmMKYprAdIFZmDmSeSHzGxZLlg6WW6x6rK2s99gs2aaxfWMPZ9/NocTRxfGFM5HzApcj1xZuTe4FPFI8U3mFeCfxCfNN45fhXyygI7BD0FXwilCq0A/hXhEVkb2i4aJfxCaJG4lfkaiQlJM8JpUvLS19QqZMVl32llyfvIv8H4WtioVKekpvldeqFKiaqP5UO6jepRGqqaT5QeuA9iSdVF0rPUG9V/pHDBYY1hrFGNuayJsym740u2C+02KJ5QSrOutcmzjbQDtXe2sHY0cdJzVnJRcFV3k3BXdlD3VPXS8Tbxsfd99gvwT//ID6wIlBS4N3hVwMfRnOFCEXaRUVEV0RMzN2T9yDBLZE3aSw5IaUNak30zkyLDIzs+ZmX8xlz7PPryjYVPiuWLskq3RV2ZsK/cqSql01jLVedVPrHzbqNdU0n22VaytsP9op3VXUfbpXta+x/+5Em0mzJ/+dGj/t8AyNmf2zvs9JmHt6vvmCpYtEFrcu+bYsc/m9lSGrTq9xWbtvveWGbZtMNm/ZarJt+w6rnft3u+45uy9s/4ODOYd+Hmk/Jn58xUnrU+fOJJ/9dX7SRe1LR68kXv13fc5Nm1t379TfU75/4mHeY7En+59lvhB5efB1/lv5dxc+NH0y/fzq64Lv4T8Ffp360/rP8f9/AA0ADzT6lvFdAAAAIGNIUk0AAHolAACAgwAA+f8AAIDpAAB1MAAA6mAAADqYAAAXb5JfxUYAAAHqSURBVHjapJUxb9NQFIW/JAip2xNS1/J+goeqUqeajdGVmFgwI1OcmYEgITFG7EgJQ+b2HzgbElJF+QU2iBl7YAFRnQ5+fnFcB0J8Jp/r53vPu+f6vYEA4JBTTjhkN/zkio9kAAihpyr1v/ijN7ovEHqiffFeDHTAdx6wL46HnPX4HM6HHNEHR0NGvRKMhvRE7wT3ACYssBggpyThIRMCAFaEzHhOiQWumfGFBQGQY0kB9EKSCsVCyKpQxUMhdOEMj4Vi91wIGX2uyNJtwTDHAgbjOUBJ/T50ETDAzCn0CiRpLkSd2VW1rqZR6uOpzHoWl40EkmkIlTIhNJc0bUSlSNNtCaZCKGtpyDZimXB92uhBhTEAHzx/BuQ8Isb62Dti16c7PahrNnbovFhXLGQaau4oqDSULDx/BcCl55cEDTUdCqqagWcXbjpqWD8ZWxRUGq5ZOTYhAXLHV0DU/qCtQLJCkZuM0PHQGThvL152JJh5M61SP2CpMpmmgdsTFDJCiaaubq0haQ7Q3xLUZq4NqzS0DNzWxNq8ksgbFmGgwf95oFgijJuB6v9L3Fx2HSg3XeExZxv1xuSEXQt/o8fqg9cDHfB15zuxjRuOETrfu/5b9bhcf+mlRmLgr/cTgp1vqR9c8YlvALcDAPr5jIx+4LKcAAAAAElFTkSuQmCC

If you copy that line, and paste it in your browser you'll see that that image is 32x32. Also, I'll check if other locales are using it and file bugs against them to make the same change.

> 
> You mean http://sq.wikipedia.org/wiki instead of the actual
> http://sq.m.wikipedia.org/wiki , don't you?

Yes, sorry, that was a very weird typo. Basically, we don't want hardcoded URL to mobile site as we want Wikipedia to use their technique and check whether it's a desktop/tablet/cellphone and do a redirect their way.

Comment 20

[Besnik Bleta]

Attachment: Patch for wikipedia-sq.xml

Milos, can you review it?

Comment 21

[Besnik Bleta]

Attachment: Edited patch for wikipedia-sq.xml

Here's the modified version after Milos' suggestions.

Comment 22

[Axel Hecht [:Pike]]

Comment on attachment 754090 [details] [diff] [review]
Edited patch for wikipedia-sq.xml

r-, this should use a 32x32 icon despite the fact that the <Image> attrs claim 16x16.

Also, please create unified diffs? They're easier to read and better supported on bugzilla.

You can make that the default by editing your ~/.hgrc, and add this section:

[diff]
git = 1

Comment 23

[Francesco Lodolo [:flod]]

Fixed as part of bug 939834 (unfortunately I missed the small icon in the first patch).

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/46efc974ff83
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/68c9c8613611