616522 - Make an exception for {key +}

Status: RESOLVED WONTFIX

(support.mozilla.org :: Knowledge Base Software, task)

Description

[[:Cww]]

I love the new {key Ctrl+K} syntax.  But if we want the + key (as in zoom) we get stuck with some broken markup no matter how we write it.  Obviously {key Ctrl + +} would be awesome but I think if we just have an exception for {key +}, we could express anything even if it means {key Ctrl} + {key +} and it's a more logical workaround.

Comment 1

[James Socol [:jsocol, :james]]

What if we space-delimited them instead? I'm not sure that's an option but then + would work like anything else.

Comment 2

[Scoobidiver (away)]

What about this solution: {key <no wiki>+</no wiki>}?
I didn't test it but I think it could work.

Comment 3

[James Socol [:jsocol, :james]]

(In reply to comment #2)
> What about this solution: {key <no wiki>+</no wiki>}?
> I didn't test it but I think it could work.

That's unlikely to work off the bat. Our custom extensions to MediaWiki syntax (like {key }) don't obey the <nowiki> tag.

On the other hand, {key &#43;} should work.


(In reply to comment #1)
> What if we space-delimited them instead? I'm not sure that's an option but then
> + would work like anything else.

If I actually think this through it's a terrible idea, since we'd be breaking everything that uses it now.

Comment 4

[David Tenser [:djst]]

(In reply to comment #3)
> (In reply to comment #2)
> > What about this solution: {key <no wiki>+</no wiki>}?
> > I didn't test it but I think it could work.
> 
> That's unlikely to work off the bat. Our custom extensions to MediaWiki syntax
> (like {key }) don't obey the <nowiki> tag.
> 
> On the other hand, {key &#43;} should work.

That looks like a perfectly reasonable workaround for this. Can anyone confirm if this works?

Comment 5

[James Socol [:jsocol, :james]]

Just tested it on master and {key Ctrl++} works as expected, i.e.: well.

Comment 6

[David Tenser [:djst]]

Then I suggest WONTFIXing this. Cheng, any objections?

Comment 7

[[:Cww]]

Yeah, I guess... I'm sad about having to go through all 40 keyboard shortcuts articles and fixing this though.

Comment 8

[David Tenser [:djst]]

Any way we can script that update instead? Seems faster...

Comment 9

[James Socol [:jsocol, :james]]

(In reply to comment #8)
> Any way we can script that update instead? Seems faster...

I'd rather take the time we'd spend writing, testing, and deploying that fix and just help change it.

Comment 10

[James Socol [:jsocol, :james]]

Just talked with Cheng and with him+localizers+a little extra help we'll just make the changes by hand.