616758 - Convert context-menu events to style described in bug 593921

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

See bug 593921 comment 8.

Myk, one thing I noticed in doing this conversion is that the descriptiveness provided by onMessage's parameter name is lost.  e.g., if my content script does a postMessage(imageURL), I could write onMessage(imageURL) and it's clear what kind of message it's expecting.  Now I have to look inside onMessage's body to see how event.data (or maybe event.data.imageURL) is used.  Not a big deal, just thought I'd mention it.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 495314 [details] [diff] [review]
patch

> Myk, one thing I noticed in doing this conversion is that the descriptiveness
> provided by onMessage's parameter name is lost.  e.g., if my content script
> does a postMessage(imageURL), I could write onMessage(imageURL) and it's clear
> what kind of message it's expecting.  Now I have to look inside onMessage's
> body to see how event.data (or maybe event.data.imageURL) is used.  Not a big
> deal, just thought I'd mention it.

Yup, it's a good point.

Note that there is a more complicated form of destructuring assignment that does provide this descriptiveness:

  onMessage: function ({ data: imageURL }) {
    // imageURL has been assigned the value of event.data
  }

One can even assign a parameter to a property of a property:

  on("click", function ({ node: { src: nodeSrc }}) {
    // nodeSrc has been assigned the value of event.node.src
  });

I'm not sure the increased descriptiveness is worth the added complexity, however, especially in the "property of a property" case.

Comment 2

[Drew Willcoxon :adw]

patch:
https://github.com/mozilla/addon-sdk/commit/6c7a11af8fb3289c68df1be56b84041edc47b523

merge:
https://github.com/mozilla/addon-sdk/commit/f80182604c663705dae3a6b58ff917a180596533

Comment 3

[Drew Willcoxon :adw]

I forgot to update the context-menu example in the Programs page of the tutorial.  It's a small change, so I pushed it as a follow-up:

https://github.com/mozilla/addon-sdk/commit/a520fff1d13149f66605d99c4e05b90d7a5e517a

Comment 4

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/420e501400e1259e89c764498fa5d1a4a307748a
https://github.com/mozilla/addon-sdk/commit/978a53822b084ac42c742dbac2cf6b1fad2763d3