Closed
Bug 616788
Opened 14 years ago
Closed 8 years ago
warning: Several warnings while trying to build gfx/cairo/libpixman including 'extern', '-Wsign-compare', '-pedantic'
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
1.43 KB,
patch
|
jrmuizel
:
review-
|
Details | Diff | Splinter Review |
In file included from gfx/cairo/libpixman/src/pixman-region16.c:49: gfx/cairo/libpixman/src/pixman-region.c: 2044: warning: ‘extern’ is not at beginning of declaration 2107: warning: ‘extern’ is not at beginning of declaration In file included from gfx/cairo/libpixman/src/pixman-region32.c:47: gfx/cairo/libpixman/src/pixman-region.c: 2044: warning: ‘extern’ is not at beginning of declaration 2107: warning: ‘extern’ is not at beginning of declaration
Updated•13 years ago
|
Whiteboard: [build_warning]
Updated•13 years ago
|
Blocks: buildwarning
Comment 2•13 years ago
|
||
Corresponding upstream bug is https://bugs.freedesktop.org/show_bug.cgi?id=42634 Moreover there are several warning apart from 'extern' ones. Pasting them below: pixman-combine.c.template: In function ‘combine_mask_ca’: pixman-combine.c.template:29:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_mask_value_ca’: pixman-combine.c.template:58:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_mask_alpha_ca’: pixman-combine.c.template:79:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_in_reverse_ca’: pixman-combine.c.template:1726:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_out_reverse_ca’: pixman-combine.c.template:1791:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_mask_ca’: pixman-combine.c.template:29:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_mask_value_ca’: pixman-combine.c.template:58:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_mask_alpha_ca’: pixman-combine.c.template:79:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_in_reverse_ca’: pixman-combine.c.template:1726:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] pixman-combine.c.template: In function ‘combine_out_reverse_ca’: pixman-combine.c.template:1791:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region16.c:49:0: /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2044:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration] In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region16.c:49:0: /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2107:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration] In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region32.c:47:0: /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2044:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration] In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region32.c:47:0: /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2107:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:113:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:114:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:115:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:116:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:117:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:118:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:119:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:120:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:121:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:122:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:123:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:124:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:125:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:126:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic] /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:127:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
Updated•13 years ago
|
Summary: warning: extern is not at beginning of declaration in <return_type_t> PIXMAN_EXPORT PREFIX (<stuff>) → warning: Several warnings while trying to build gfx/cairo/libpixman including 'extern', '-Wsign-compare', '-pedantic'
Comment 3•11 years ago
|
||
Comment on attachment 495343 [details] [diff] [review] patch This should be submitted upstream
Attachment #495343 -
Flags: review?(jmuizelaar) → review-
Comment 4•8 years ago
|
||
Fixes for warnings in third-party code should be submitted upstream, not patched in mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•