Closed Bug 617246 Opened 14 years ago Closed 13 years ago

Cdecl refactoring

Categories

(Tamarin Graveyard :: Virtual Machine, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alexmac, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_5; en-us) AppleWebKit/533.19.4 (KHTML, like Gecko) Version/5.0.3 Safari/533.19.4
Build Identifier: 

The diff looks gigantic but only because I fixed the whitespace and removed tabs throughout the file, view it ignoring ws to see the functional changes.

Some of the work to enable exact callmethod for aot required small changes to the argument coercion code used in cdecl and fixed some bugs with the size of the argdesc computation.

Reproducible: Always
Attached patch Cdecl refactoring (obsolete) — Splinter Review
Attachment #495754 - Flags: review?(stejohns)
(In reply to comment #0)
> The diff looks gigantic but only because I fixed the whitespace and removed
> tabs throughout the file, view it ignoring ws to see the functional changes.

For future reference, it's usually preferred to upload diffs without the whitespace fixes, and fix the whitespace when you push.
Attachment #495754 - Flags: review?(stejohns) → review+
Blocks: 617254
Attachment #495754 - Attachment is obsolete: true
Blocks: 616780
Blocks: 620678
Attachment #499003 - Flags: review+
TR 5851:bb1d051d4827
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: