617848 - try_parser is giving unusual results on -p all with -b o or -b d

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Karl Tomlinson (:karlt)]

ba9807fd9cf9 has "try: -p all -b d -u all -t none" but no OSX 10.5.8 builds.

b5f5ea65ad37 has "try: -b o -p all -u reftest,opengl,mochitests -t none" but a number of leak test builds are running.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Thank you for pointing these out. They are valid try_parser bugs.  

In the first instance, this is how the try push was translated and it looks like macosx-debug does not generate the 10.5.2 tryserver leak test build:

TryChooser OPTIONS : MESSAGE Namespace(build=['debug'], do_everything=False, talos=u'none', test=u'all', user_platforms=['win32-debug', 'macosx64-debug', 'linux64-debug', 'macosx64', 'win32', 'linux64', 'linux', 'macosx-debug', 'linux-debug']) : try: -p all -b d -u all -t none

On the other hand, this push for 51c4de99b041 does get that builder:
TryChooser OPTIONS : MESSAGE Namespace(build=['opt', 'debug'], do_everything=False, talos=u'none', test=u'mochitest-o', user_platforms=['win32-debug', 'macosx64-debug', 'linux64-debug', 'macosx64', 'win32', 'linux64', 'linux', 'macosx-debug', 'linux-debug']) : Bug 604098 - Double click anywhere to create a new tab try: -b do -p all -u mochitest-o -m none -t none
2010-12-09 12:11:03-0800 [-] Adding request for {<buildbot.changes.changes.Change instance at 0xb10aa0c>: ['WINNT 5.2 tryserver leak test build', 'OS X 10.6.2 tryserver leak test build', 'Linux x86-64 tryserver leak test build', 'OS X 10.6.2 tryserver build', 'WINNT 5.2 tryserver build', 'Linux x86-64 tryserver build', 'Linux tryserver build', 'OS X 10.5.2 tryserver leak test build', 'Linux tryserver leak test build']}


In the second instance, the debug platforms are being sent in when they shouldn't:

TryChooser OPTIONS : MESSAGE Namespace(build=['opt'], do_everything=False, talos=u'none', test=u'reftest,opengl,mochitests', user_platforms=['win32-debug', 'macosx64-debug', 'linux64-debug', 'macosx64', 'win32', 'linux64', 'linux', 'macosx-debug', 'linux-debug']) : try: -b o -p all -u reftest,opengl,mochitests -t none


I will have to look more closely at what is happening with the -p all here.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Fixes -p all for opt/debug when not 'od' or 'do'

Also added new tests to make sure this works as required.

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 500952 [details] [diff] [review]
Fixes -p all for opt/debug when not 'od' or 'do'

That looks like it'll work from where I'm standing.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 500952 [details] [diff] [review]
Fixes -p all for opt/debug when not 'od' or 'do'

landed: http://hg.mozilla.org/build/buildbotcustom/rev/532be9b13696
reconfig'd try master.