Closed
Bug 617953
Opened 14 years ago
Closed 13 years ago
Hunspell::analyze leaks p = pSMgr->suggest_morph()
Categories
(Core :: Spelling checker, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | ? |
People
(Reporter: timeless, Assigned: caolanm)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak, Whiteboard: [fixed-in-hunspell-1.2.13])
Attachments
(1 file)
|
782 bytes,
patch
|
timeless
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
1379 int Hunspell::analyze(char*** slst, const char * word)
1380 {
1530 if (spell(cw)) {
1531 char * p = pSMgr->suggest_morph(cw);
1532 if (p) return line_tok(pSMgr->suggest_morph(cw), slst, MSEP_REC);
1533 }
line 1532 should be passing p instead of calling the same function again
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #496559 -
Flags: review+
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13]
|
|
||
Updated•14 years ago
|
Depends on: hunspell-1.3.2
|
||
Updated•13 years ago
|
Attachment #496559 -
Flags: approval2.0?
Attachment #496559 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•13 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13] → [fixed-in-hunspell-1.2.13][needs landing]
|
|
||
Updated•13 years ago
|
Keywords: 4xp,
checkin-needed
|
||
Comment 2•13 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/6a05c245907e
Assignee: nobody → caolanm
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
status1.9.2:
--- → ?
|
|
||
Updated•13 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13][needs landing] → [fixed-in-hunspell-1.2.13]
|
|
||
Comment 3•13 years ago
|
||
I think you need to request branch approval, Ryan, if you want this on 1.9.2.
|
|
||
Comment 4•13 years ago
|
||
Not sure if it's worth taking on 1.9.2 or not. I figured I'd ask approval if the drivers want to take these fixes. We obviously need to take the topcrash fix, though.
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•