618770 - Titlebar gradient breaks off abruptly at the toolbar in windows without tab bar when tabs are set on top

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Bram Pitoyo [:bram]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_5; en-US) AppleWebKit/534.13 (KHTML, like Gecko) Chrome/9.0.597.16 Safari/534.13
Build Identifier: Trunk

The gradient in the titlebar breaks off abruptly at the point at which it touches the toolbar when: 1) tabs is set on top, and 2) there is no tab open.

Educated guess/possible problem: the chrome stretches the gradient value down to fit an unexpanded space, creating a color that does not blend with its bottom neighbor

The same problem is also seen in the inactive window, though less pronounced.

Reproducible: Always

Steps to Reproduce:
1. Set Minefield to use Tabs on Top
2. Close all open tabs, leaving one open
Actual Results:  
Titlebar gradient eliminate abruptly at the toolbar.

Expected Results:  
Gradient should flow smoothly

Comment 1

[Bram Pitoyo [:bram]]

Attachment: Broken titlebar gradient when tabs is set on top

Comment 2

[Markus Stange [:mstange]]

Dão, is it possible for the #nav-bar to tell whether the tabs toolbar is visible or not? If not, should we add an attribute to the toolbox?

Comment 5

[u220127]

Attachment: Gradient broken on a toolbarless window

I only see this effect in toolbar-less pop-up windows.
4.0b11pre(2011-01-31)
Mac OS 10.6.6

Comment 6

[u220127]

(In reply to comment #5)
Forgot to add, that this is also happening only with the 'Tabs on top' option enabled.

Comment 9

[Kevin Cannon]

Just to confirm, this is still a problem in Firefox 4 RC2.

It happens whenever the tab bar is not visible.

This can happen in many situations such as popup windows, and also simply having no tabs open and the 'always show tab bar' setting unchecked.

Comment 10

[Bram Pitoyo [:bram]]

Firefox 4 works around this bug by having this "always show tab bar" setting turned on by default. Minefield doesn’t have this option, though.

Maybe we could implement this feature on Minefield so it’s easier to perform testing on this and other gradient-related bugs?

Comment 12

[Bram Pitoyo [:bram]]

(In reply to comment #2)
> Dão, is it possible for the #nav-bar to tell whether the tabs toolbar is
> visible or not? If not, should we add an attribute to the toolbox?

I wonder if this bug is related to Bug 537273 - Make -moz-appearance: toolbar also draw a gradient if the toolbar is at the top of a drawintitlebar="true" window

https://bugzilla.mozilla.org/show_bug.cgi?id=537273

Comment 13

[Anthony Ricaud (:rik)]

I was gonnna comment that this is fixed with the new look on latest Nightly.

But actually, I'm not seeing this under Aurora on 10.7 either. So it seems to be 10.5/10.6 only now.

Comment 14

[Loic Nageleisen]

I'm still seeing it under both today's nightly and Aurora 7.0a2 on 10.7.

Comment 15

[Anthony Ricaud (:rik)]

Actually yeah, disregard Comment 13, bad testing on my part.

Comment 16

[Bram Pitoyo [:bram]]

I wonder if this bug depends on #<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=668195">668195</a>?

Comment 17

[Bram Pitoyo [:bram]]

I meant to say Bug 668195. Sorry.

Comment 18

[Markus Stange [:mstange]]

Attachment: v1

Comment 21

[Dão Gottwald [:dao]]

Comment on attachment 552342 [details] [diff] [review]
v1

I don't like the addition of the visibletabsontop attribute. Can we just not set the tabsontop attribute in that case? We'll need to remove persist="tabsontop" in browser.xul for that and do the persisting in the script.

Comment 22

[Markus Stange [:mstange]]

I've tried that idea and it didn't really work out. What should happen if somebody toggles the tabsontop checkbox while tabs are hidden? What values should the enabled getter return during that time? If the getter doesn't read the current state from tabsontop attribute, how should it know about the persisted value?

Comment 23

[Dão Gottwald [:dao]]

(In reply to Markus Stange from comment #22)
> I've tried that idea and it didn't really work out. What should happen if
> somebody toggles the tabsontop checkbox while tabs are hidden?

The checkbox should probably be disabled or hidden; it might make sense to let the toggle function do nothing in that case, too.

> What values should the enabled getter return during that time?

Based on the two external places that read TabsOnTop.enabled, I'd say it should reflect the actual attribute state (not what's persisted).

Comment 24

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 25

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 580788 [details] [diff] [review]
patch v2

Review of attachment 580788 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/nsBrowserGlue.js
@@ +1223,5 @@
>      }
>  
> +    if (currentUIVersion < 6) {
> +      // convert tabsontop attribute to pref
> +      let tooloxResource = this._rdf.GetResource(BROWSER_DOCURL + "navigator-toolbox");

nit: This should probably be toolboxResource

Comment 26

[Dão Gottwald [:dao]]

Attachment: patch v2

typofix

Comment 27

[Justin Dolske [:Dolske]]

Comment on attachment 580966 [details] [diff] [review]
patch v2

Review of attachment 580966 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't review this in depth, but looks fine. Flag again if you want a nitpicky review. :)

Comment 28

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5fbe5ee99a27

Comment 29

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #28)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/5fbe5ee99a27

backed out because browser_bug321000.js was failing

Comment 30

[Ed Morley [:emorley]]

The fix to the ally test has now been merged to m-c (https://hg.mozilla.org/mozilla-central/rev/e1b77400dc94), leaving open for the relanding of the main patch.

Comment 31

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/440b585a2896

Comment 32

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/440b585a2896

Comment 33

[Mehmet]

There is a issue now. Filed bug 716334. Thanks.

Comment 35

[Mehmet]

Hi, there is still a bug. I filed bug 737158. Thanks.