Closed Bug 6188 Opened 25 years ago Closed 25 years ago

Netlib returns NS_FALSE on errors

Categories

(Core :: Networking, defect, P3)

Product:
Core
Component:
Networking
Platform:
All
Mac System 8.5
Type:
defect

Tracking

()

Status:
VERIFIED INVALID

People

(Reporter: sfraser_bugs, Assigned: warrensomebody)

References

Details

In various places (I counted 14), netlib is returning NS_FALSE on error. NS_FALSE
is #defined to 1 (really, NS_COMFALSE should be used if you want to return
this value at all).

The problem with returning NS_FALSE is that NS_SUCCEEDED(NS_FALSE) evaluates
to true, so callers who rely on SUCCEEDED() incorrectly assume that the call
succeeded.

Netlib should be returning real errors, preferably errors which useful
meanings.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
Verify that this doesn't happen in necko.

*** This bug has been marked as a duplicate of 5571 ***
Status: RESOLVED → REOPENED
This has nothing to do with #5571. Sorry, wrong number.

Reopening.
Resolution: DUPLICATE → ---
Remove duplicate resolution
Why is this not a duplicate?
Why would this be a duplicate of a bug concering the file locator?
*** Bug 5675 has been marked as a duplicate of this bug. ***
Status: REOPENED → ASSIGNED
Depends on: 7232
Sorry, that should have been #5657. I'm going to mark that one a dup of this.
No longer depends on: 7232
Blocks: 7232
Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → INVALID
Not an issue with necko.
Status: RESOLVED → VERIFIED
I will trust you on this
Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.
You need to log in before you can comment on or make changes to this bug.