Closed
Bug 619231
Opened 14 years ago
Closed 13 years ago
Fennec UI should not enable Connect unless all fields are entered
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(fennec2.0+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0+ | --- |
People
(Reporter: ashah, Assigned: mfinkle)
References
Details
(Whiteboard: [e0])
Attachments
(1 file)
4.22 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0(Android; Linux armv7l; rv:2.0b8pre) Gecko/20101214 Firefox/4.0b8pre Fennec/4.0b3pre STR: 1. Open Fennec > Preferences 2. Make sure that you are not connectd to Sync. 3. Click on the "Connect" button. 4. Click on "I am not near my computer" 5. In the login screen that is shown, do not enter anything. Click "connect" Expected Result: Nothing should happen Actual Result: You are taken to the preferences page and the Sync shows "Not Connected. Unknown Error"
Reporter | ||
Updated•14 years ago
|
tracking-fennec: --- → ?
Comment 1•14 years ago
|
||
This is another example of unhelpful error messages. lets track all this and figure out how to redesign the workflow.
Assignee | ||
Updated•14 years ago
|
Product: Fennec → Mozilla Services
QA Contact: general → general
Version: Trunk → unspecified
Comment 2•14 years ago
|
||
I'm not so sure this is a Sync bug. It seems more like a Fennec UI bug. The Firefox UI ensures that it doesn't call into Weave.Service with obviously bogus inputs (e.g. empty strings). In fact, it disables the buttons for such cases.
Comment 3•14 years ago
|
||
Yeah, concur, the UI should prevent this, rather than have us add strings for cases that UI shouldn't allow.
Product: Mozilla Services → Fennec
QA Contact: general → general
Summary: Incorrect error message shown when nothing entered in sync login → Fennec UI should not enable Connect unless all fields are entered
Version: unspecified → Trunk
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → mark.finkle
tracking-fennec: ? → 2.0+
Assignee | ||
Updated•13 years ago
|
Priority: -- → P2
Whiteboard: [e0]
Assignee | ||
Comment 5•13 years ago
|
||
Adds code to enable / disable the "Connect" button. Checks when opening the manual dialog and as you type in the account, password and synckey fields. All fields must have some text before the "Connect" button is enabled.
Attachment #507472 -
Flags: review?(21)
Comment 6•13 years ago
|
||
Comment on attachment 507472 [details] [diff] [review] patch >diff --git a/chrome/content/sync.js b/chrome/content/sync.js >+ if (account && password && synckey) >+ document.getElementById("syncsetup-button-connect").disabled = false; >+ else >+ document.getElementById("syncsetup-button-connect").disabled = true; >+ }, Nit: let disabled = !(account && password && synckey); document.getElementById("syncsetup-button-connect").disabled = disabled;
Attachment #507472 -
Flags: review?(21) → review+
Assignee | ||
Comment 7•13 years ago
|
||
pushed with nit fixed: http://hg.mozilla.org/mobile-browser/rev/ba751c096419
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 8•13 years ago
|
||
verified fixed on build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110304 Firefox/4.0b13pre Fennec /4.0b6pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•