619296 - Java class wrapping not customizable via WrapFactory

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Hannes Wallnoefer]

The WrapFactory class is supposed to provide an interface for customizing Java object wrapping, but Java classes (an important subset of java objects) are currently not passed through it. Instead, Java class wrapping is hard-coded to NativeJavaClass.

Comment 1

[Hannes Wallnoefer]

Calling java classes a subset of java objects as I did above is nonsense of course. Still, being able to control class wrapper creation alongside object wrapper creation makes a lot of sense to me.

Comment 2

[Hannes Wallnoefer]

Attachment: Add wrapJavaClass() method to WrapFactory

Adds a wrapJavaClass() method to WrapFactory that returns a new NativeJavaClass. Replace all instances of NativeJavaClass instantiation with calls to WrapFactory.wrapJavaClass().

Comment 3

[Hannes Wallnoefer]

I committed my patch.

Checking in src/org/mozilla/javascript/NativeJavaClass.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeJavaClass.java,v  <--  NativeJavaClass.java
new revision: 1.56; previous revision: 1.55
done
Checking in src/org/mozilla/javascript/NativeJavaPackage.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeJavaPackage.java,v  <--  NativeJavaPackage.java
new revision: 1.46; previous revision: 1.45
done
Checking in src/org/mozilla/javascript/WrapFactory.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/WrapFactory.java,v  <--  WrapFactory.java
new revision: 1.21; previous revision: 1.20
done