Closed
Bug 619780
Opened 14 years ago
Closed 13 years ago
talos needs to support environment variables on remote testing
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [mobile_unittests])
Attachments
(2 files, 2 obsolete files)
17.26 KB,
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
9.42 KB,
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
currently we need to disable crashreporter and this requires us adding environment variables into the command that we send to android. instead of: 'exec org.mozilla.fennec -profile /tmp/profile http://my/test.html' it needs to be: 'exec "MOZ_CRASHREPORTER_NO_REPORT=1" org.mozilla.fennec -profile /tmp/profile http://my/test.html'
Attachment #498207 -
Flags: review?(anodelman)
Assignee | ||
Comment 1•14 years ago
|
||
secondary patch which fixes the talos code to support the environment variables on the command line which android needs. These will be running on talos staging
Assignee: nobody → jmaher
Attachment #498208 -
Flags: review?(anodelman)
Assignee | ||
Comment 2•14 years ago
|
||
updated patch to fix a few devicemanager specific things.
Attachment #498207 -
Attachment is obsolete: true
Attachment #498336 -
Flags: review?(anodelman)
Attachment #498207 -
Flags: review?(anodelman)
Assignee | ||
Comment 3•14 years ago
|
||
moved stuff out of here into the devicemanager patch to keep it unique. Also added in a new ENV variable that mobile supports as well as a cleanup on the run_tests.py application.ini discovery.
Attachment #498208 -
Attachment is obsolete: true
Attachment #498337 -
Flags: review?(anodelman)
Attachment #498208 -
Flags: review?(anodelman)
Assignee | ||
Comment 4•14 years ago
|
||
updated both patches. The original patches were green on try! I am running these new patches on try and we will see the results. I will have to update the results in this bug this weekend as I will be AFK the majority of today.
Comment 5•14 years ago
|
||
Please update when you get a green run through so that I can complete my review.
Updated•14 years ago
|
Attachment #498336 -
Flags: review?(anodelman) → review+
Updated•14 years ago
|
Attachment #498337 -
Flags: review?(anodelman) → review+
Comment 6•14 years ago
|
||
Just a general comment that we may need to clean up in future the general case setting of env vars from the specific remote setting - instead of just having one thing called 'env' might be smarter to split into local_env and remote_env and then handle those things separately. Could just become confusing when pretty much the same config file has different results depending on if you are running remote or not.
Assignee | ||
Comment 7•14 years ago
|
||
as a note, these passed talos staging all green.
Assignee | ||
Comment 8•14 years ago
|
||
landed: http://hg.mozilla.org/build/talos/pushloghtml?changeset=3efbac1f685a http://hg.mozilla.org/build/talos/pushloghtml?changeset=aa376673fab5 I filed bug 620104 to track the remote vs local environment variable issue.
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•