619808 - Sync errors are not localized for beta 3

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

while the sync setup screens are localized for some of the locales, the error messages aren't.  Messages like "Wrong Sync Key", "Unknown Errors", "Unable to sync", etc..   

Should these be blocking beta 3 or pushed to future?   

Repro:
1) install fennec 4 beta 3 on android, multi-locale build
2) change to a tier 1 locale (eg. French, Italian)
3) try to sync
4) Verify the easy setup and fallback UI screens are localized, but the error messages (when you cannot sync), are not.

Expected:
- Error messages for syncing should be localized

ActuaL:
- error messages still in english.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We are pulling error messages from the toolkit sync code, not from Fennec

Comment 2

[Philipp von Weitershausen [:philikon]]

They are localized in Sync and show up translated in localized versions of Firefox. Perhaps you're not pulling in the right bits anymore. I definitely remember this was a problem in the past (bug 605414).

Anyway, doesn't seem like a Sync bug to me.

Comment 3

[Philipp von Weitershausen [:philikon]]

Axel, do you have any idea what could be causing this?

Comment 4

[Axel Hecht [:Pike]]

Looking at http://releases.mozilla.org/pub/mozilla.org/mobile/releases/4.0b3/android-r7/multi/fennec-4.0b3.multi.eabi-arm.apk:

The fr.manifest doesn't include a line for

locale weave en-US en-US/locale/en-US/


http://hg.mozilla.org/mobile-browser/annotate/FENNEC_4_0b3_RELEASE/locales/Makefile.in on the other hand says that it should be building services/sync.

Over to releng for investigation.

Comment 5

[Axel Hecht [:Pike]]

Actually I bet this is a bad fix in bug 606725. Doh, I reviewed that. I forgot way too much about how things worked there.

I'm pretty sure it shouldn't have XPI_NAME and BOTH_MANIFESTS for chrome-%.

Back over to fennec.

Comment 6

[Axel Hecht [:Pike]]

Attachment: call into services/sync, without langpack mojo, and chrome target only

Mark, I only tested the output of the chrome-% target. With these changes, the french services files are in and fr.manifest lists them. Should be good. I don't have a device to test an actual build, though.

Comment 7

[Axel Hecht [:Pike]]

http://hg.mozilla.org/mobile-browser/rev/27501148f792, FIXED.

Comment 8

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110526 Firefox/7.0a1 Fennec/7.0a1 

Device: HTC Desire Z (Android 2.2)