Closed Bug 620022 Opened 14 years ago Closed 14 years ago

should clear message display when switching to summarize view

Categories

(Thunderbird :: Message Reader UI, defect)

Product:
Thunderbird
Component:
Message Reader UI
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.3a2

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Whiteboard: duptome)

Attachments

(1 file, 2 obsolete files)

fix with mozmill test
1.81 KB, patch
rain1
: review+
Details | Diff | Splinter Review 
STR:

1. Select a single message.
2. control select a different message.
3. Select a third message.

The single message flashes, and then we display the third message. We shouldn't display the first message (it's just because we're switching which browser messagepanebox uses in messenger.xul, so we briefly redisplay the browser containing the first message). If we happen to reselect the first message, then the current behavior would be a win, but that happens way less than half the time.

My proposal is to clear the message pane when we switch from displaying a single message to message summaries. Patch upcoming.
Attached patch proposed fix (obsolete) — — Splinter Review 
The only mozmill test I can imagine would be to check that the displayed message after the selection is summarized is "about:blank". I'll see if I can figure out how to do that.
Attachment #498465 - Flags: review?(sid.bugzilla)
Attached patch fix with mozmill test (obsolete) — — Splinter Review 

        Attachment #498465 -
        Attachment is obsolete: true

        Attachment #498657 -
        Flags: review?(sid.bugzilla)

        Attachment #498465 -
        Flags: review?(sid.bugzilla)

    
    

    
  
The patch is the same as the last one...

    
    

    
  


  
oops, this should have the mozmill test change.

        Attachment #498657 -
        Attachment is obsolete: true

        Attachment #498732 -
        Flags: review?(sid.bugzilla)

        Attachment #498657 -
        Flags: review?(sid.bugzilla)

    
    

    
  
Comment on attachment 498732 [details] [diff] [review]
fix with mozmill test

I'd prefer that the test be moved to inside _internal_assert_displayed to be just that tiny bit more comprehensive, but I'm going to leave it to you.

        Attachment #498732 -
        Flags: review?(sid.bugzilla) → review+
Whiteboard: duptome

    
    

    
  
fix checked in with comment addressed.

changeset:   6867:e0d93e431325
tag:         tip
user:        David Bienvenu <bienvenu@nventure.com>
date:        Tue Dec 21 10:38:08 2010 -0800
summary:     clear message display when summarizing messages, r=sid0, bug 620022
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: