620138 - Toolbar corner not rounded when using in-content UI like add-on manager

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[redsign]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101218 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101218 Firefox/4.0b9pre

The corners of the toolbar are rounded since the landing of Bug 589259 - top outside corners of navigation toolbar need border radius. The corners become rectangular again when viewing in-content UI like the new add-on manager. 

Reproducible: Always

Steps to Reproduce:
1.Open the add-on manager

Actual Results:  
The top outside corners of the browser chrome become rectangular.

Expected Results:  
The corners should be rounded as before.

Comment 1

[redsign]

Attachment: Comparison of the outside corners with and without in-content UI

Outside corner with a tab showing a regular website on the left and with showing the add-on manager on the right.

Comment 2

[Ed Morley [:emorley]]

Confirmed with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101217 Firefox/4.0b9pre ID:20101217030324

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Also works pretty well with the patch with bug 644721 (aside from the bitrot).

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/9c3ea24a7bff

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/9c3ea24a7bff

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Vlad, could you please verify this bug on Win7? Currently I do not have access to such a machine. Thanks.

Comment 7

[bogas04]

Are you sure it looks good?

http://s4.postimage.org/60970dyka/Untitled.png

http://s4.postimage.org/fzt0vrmzz/Untitled.png

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Bogas, does it look the same with a Nightly build for you? Not sure if there have been landed any other patches on the UX branch which could affect this.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Note that the UX branch contains unfinished patches - such as the patch from bug 644721, which will need updating to take into account the fix for this bug. Part of the bitrot I mentioned in comment 3 is taking into account the CSS changes made in this bug.

Comment 10

[Trif Andrei-Alin[:AlinT]]

Mozilla/5.0 (Windows NT 6.1; rv:8.0a2) Gecko/20110825 Firefox/8.0a2

It has been fixed on latest Aurora and Nightly.
Setting resolution to Verified Fixed.
Thanks.