62015 - Move pref "intl.collationKeyAsCodePoint" to chrome directory

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P2)

Description

[ji]

We need this pref to be able to sort correctly on linux.
For 6.0, this is put in all.js in Japanese linux build.

Comment 1

[nhottanscp]

Yes, it has to be moved to .property file and need to change the related .cpp file.

Comment 2

[Katsuhiko Momoi]

Is it navigator.properties, then?

Comment 3

[nhottanscp]

>Is it navigator.properties, then?

yes

Comment 4

[msanz]

adding intl

Comment 5

[nhottanscp]

intl -> l12y

Comment 6

[nhottanscp]

"intl.collationKeyAsCodePoint" is a bool pref. There is no
getLocalizedBoolPref() in nsIPref.
Tao, do you think we should create getLocalizedBoolPref()?
For this bug, I can change "intl.collationKeyAsCodePoint" to a char pref instead
of bool.

Comment 7

[tao]

Alecf owns the getLocalizedXX() api. IMO, your proposal will work. No need to
add another api just for this particular bug.

Comment 8

[Katsuhiko Momoi]

Mass change of QA contact to ji for the bugs filed by her.

Comment 9

[nhottanscp]

Attachment: Patch, moved the pref to property

Comment 10

[tao]

r=tao if the default value of this pref is null in navigator.properties

Comment 11

[Erik van der Poel]

How about a slightly better wording, for understandability:

  mKeyAsCodePoint -> mUseCodePointOrder
  collationKeyAsCodePoint -> useCodePointOrder

Also, expand the comment in the property file to:

  valid collation options are: <empty string> or useCodePointOrder

sr=erik

Comment 12

[nhottanscp]

checked in

Comment 13

[ji]

With 04/10 build, in the file of .../locale/en-US/navigator/navigator.properties
I saw the pref of "intl.collationOption"
Naoki, did you change it to a char pref or bool pref?

Comment 14

[nhottanscp]

That's a char pref, the possible value are listed as in the file.

 29 # valid collation options are: <empty string> or useCodePointOrder

Comment 15

[ji]

Thanks. Verified as fixed.
Added Ying and Ray to cc list. We need this pref set to useCodePointOrder
for Japanese linux build.