620360 - Fix unused variable warning in StatementCache::FinalizeCachedStatements

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Since bug 599969, rv has been unused in opt builds.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 498720 [details] [diff] [review]
Patch v1

>-    nsresult rv = aStatement->Finalize();
>+#ifdef DEBUG
>+    nsresult rv =
>+#endif
>+    aStatement->Finalize();
>     NS_WARN_IF_FALSE(NS_SUCCEEDED(rv), "Finalizing statement failed!");
It's actually silly to warn since storage code will also warn.  Just change the line to :
(void)aStatement->Finalize();

r=sdwilsh with that change.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Thanks.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Comment 4

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/c544c99fad5a