620452 - jsemit.cpp compile failure when #undef JS_HAS_SHARP_VARS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Paprocki]

Attachment: Define sharpnum always

The definition of the EmitNewInit() static function in jsemit.cpp always has a "sharpnum" argument. This function is called 3 times within the file outside of JS_HAS_SHARP_VARS checks passing the "sharpnum" variable. This variable is only defined when JS_HAS_SHARP_VARS is defined, thus breaking the build.

The attached patch simply always defines the variable since it is always passed to EmitNewInit(). I assume this is preferred over putting the definition of EmitNewInit() as well as all the callers inside #ifdefs.

Comment 1

[Andrew Paprocki]

Attachment: Define sharpnum always

Revisiting old bugs, rebased patch to mozilla-inbound.

Comment 2

[Ed Morley [:emorley]]

{
applying thg-import-agrin7.patch
unable to find 'js/src/frontend/BytecodeGenerator.cpp' for patching
1 out of 1 hunks FAILED -- saving rejects to file js/src/frontend/BytecodeGenerator.cpp.rej
}

Comment 3

[Andrew Paprocki]

Ed, this checkin failed? Were you applying the patch to mozilla-inbound?

Comment 4

[Ed Morley [:emorley]]

Yeah sorry meant to put was applying to inbound.
Thanks :-)

Comment 5

[Andrew Paprocki]

Attachment: Always define sharpnum

Updated patch to apply clean to m-i.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/215ba0c3d5b7

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/215ba0c3d5b7